jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Fix installation of libgit2 into wrong libdir #624

Merged
pks-t merged 1 commits from pks/vendored-build-libdir into master 2020-07-25 15:08:05 -05:00
Conversation 1 Commits 1 Files Changed 1 +1
pks-t commented 2020-07-23 03:12:34 -05:00 (Migrated from github.com)
Copy Link

Upstream libgit2 has migrated to use the GNUInstallDirs module to decide
where things will be installed to by default. While it improves
consistency with the host system, we're not really after that when
building the vendored libgit2 library, and in fact libgit2.{a,pc} may
now be installed into a different directory than before as it started to
depend on the host platform.

Fix this by explicitly specifying that we want the library and pkgconfig
file to be installed into a plain "lib/" directory.

Upstream libgit2 has migrated to use the GNUInstallDirs module to decide where things will be installed to by default. While it improves consistency with the host system, we're not really after that when building the vendored libgit2 library, and in fact libgit2.{a,pc} may now be installed into a different directory than before as it started to depend on the host platform. Fix this by explicitly specifying that we want the library and pkgconfig file to be installed into a plain "lib/" directory.
pks-t commented 2020-07-23 03:14:50 -05:00 (Migrated from github.com)
Copy Link

We may also want to backport this to the v30 branch as it currently breaks install-static on some (most?) platforms completely.

We may also want to backport this to the v30 branch as it currently breaks install-static on some (most?) platforms completely.
lhchavez (Migrated from github.com) approved these changes 2020-07-25 15:07:52 -05:00
lhchavez (Migrated from github.com) left a comment
Copy Link

thanks! i still need to set up the automatic cherry-picker mechanism, so i'll do that by hand later.

thanks! i still need to set up the automatic cherry-picker mechanism, so i'll do that by hand later.
Sign in to join this conversation.
Reviewers
No reviewers
lhchavez
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#624
No description provided.
Delete Branch "pks/vendored-build-libdir"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?