Use time.Time in the Signature struct #6

2013-03-06T13:38:28-06:00

carlosmn commented

2013-03-06 13:38:28 -06:00

(Migrated from github.com)

The antisymmetry of sig.When.Unix() vs sig.Offset() isn't great, but getting the offset in seconds becomes annoying otherwise, as time.Time wants to give you the timezone's name as well, and gives you the offset in seconds, while we want it in minutes.

Do we want a sig.Unix() function that just returns sig.When.Unix()?

The antisymmetry of `sig.When.Unix()` vs `sig.Offset()` isn't great, but getting the offset in seconds becomes annoying otherwise, as `time.Time` wants to give you the timezone's name as well, and gives you the offset in seconds, while we want it in minutes. Do we want a `sig.Unix()` function that just returns `sig.When.Unix()`?

vmg commented

2013-03-06 13:40:24 -06:00

(Migrated from github.com)

Looks just fine to me.

Sign in to join this conversation.

No reviewers