jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

README: master wants to use install-static #413

Merged
carlosmn merged 2 commits from cmn/master-static into master 2017-10-16 08:42:46 -05:00
Conversation 6 Commits 2 Files Changed 1 +5 -5
carlosmn commented 2017-10-16 08:14:37 -05:00 (Migrated from github.com)
Copy Link
No description provided.
mhagger commented 2017-10-16 08:18:52 -05:00 (Migrated from github.com)
Copy Link

@carlosmn: Thanks. When building I also had a problem that pkg-config couldn't find libgit2.pc. I solved it by running

PKG_CONFIG_PATH=vendor/libgit2/build make install-static

but there might be a better way.

@carlosmn: Thanks. When building I also had a problem that `pkg-config` couldn't find `libgit2.pc`. I solved it by running PKG_CONFIG_PATH=vendor/libgit2/build make install-static but there might be a better way.
carlosmn commented 2017-10-16 08:22:14 -05:00 (Migrated from github.com)
Copy Link

What Go version are you on? We pass the pc file directly to pkg-config in dc745f54c5/git_static.go (L9)

/cc #408 which seems to be about the same issue

What Go version are you on? We pass the pc file directly to `pkg-config` in https://github.com/libgit2/git2go/blob/dc745f54c5690276bc3bdf83f27f751295a816ff/git_static.go#L9 /cc #408 which seems to be about the same issue
mhagger commented 2017-10-16 08:26:55 -05:00 (Migrated from github.com)
Copy Link

What Go version are you on?

go1.8.1

> What Go version are you on? go1.8.1
mhagger commented 2017-10-16 08:29:36 -05:00 (Migrated from github.com)
Copy Link

Hmmm, maybe that error was happening before I figured out that I had to use install-static rather than install. Let me check again more carefully.

Hmmm, maybe that error was happening before I figured out that I had to use `install-static` rather than `install`. Let me check again more carefully.
mhagger commented 2017-10-16 08:35:32 -05:00 (Migrated from github.com)
Copy Link

Yes, it seems that make install-static works without having to set a PKG_CONFIG_PATH. It was only when I was following the old instructions step by step that the first error emitted by make install could be solved by setting PKG_CONFIG_PATH. Sorry for the confusion.

Yes, it seems that `make install-static` works without having to set a `PKG_CONFIG_PATH`. It was only when I was following the old instructions step by step that the first error emitted by `make install` could be solved by setting `PKG_CONFIG_PATH`. Sorry for the confusion.
carlosmn commented 2017-10-16 08:43:26 -05:00 (Migrated from github.com)
Copy Link

It does give us an explanation, so we have that at least.

It does give us an explanation, so we have that at least.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#413
No description provided.
Delete Branch "cmn/master-static"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?