jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

rebase: fix int overflows on GIT_REBASE_NO_OPERATION #385

Closed
zchee wants to merge 1 commits from rebase-overflows_int into master
Conversation 2 Commits 1 Files Changed 1 +3 -3
zchee commented 2017-06-11 10:54:58 -05:00 (Migrated from github.com)

Fix int overflows on GIT_REBASE_NO_OPERATION.
It will fail on Go tip(and maybe 1.8), See https://travis-ci.org/libgit2/git2go/jobs/234362572#L391-L392.

Fix int overflows on `GIT_REBASE_NO_OPERATION`. It will fail on Go tip(and maybe 1.8), See https://travis-ci.org/libgit2/git2go/jobs/234362572#L391-L392.
carlosmn commented 2017-07-08 11:35:01 -05:00 (Migrated from github.com)

C.GIT_REBASE_NO_OPERATION is not en error code, so the error isn't the mismatched sizes but a mismatch in the kind of return values that the Go code provides vs what libgit2 is actually returning.

`C.GIT_REBASE_NO_OPERATION` is not en error code, so the error isn't the mismatched sizes but a mismatch in the kind of return values that the Go code provides vs what libgit2 is actually returning.
carlosmn commented 2017-07-08 15:23:22 -05:00 (Migrated from github.com)

Superseded by

Superseded by #396

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#385
No description provided.
Delete Branch "rebase-overflows_int"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?