Use variable substitution instead of a wrapper script #338

2016-08-27T15:05:04-05:00

carlosmn commented

2016-08-27 15:05:04 -05:00

(Migrated from github.com)

From 1.5 onward the build tool supports variable substitution in the cgo directives. This makes us use that instead of the wrapper script. Once the vendored libgit2 is built the 'next' branch can thus also be used with the usual commands go build, go test without having to use the Makefile or calling the wrapping script.

We still can't tell the build tool to build libgit2, so we still need a script for that.

From 1.5 onward the build tool supports variable substitution in the cgo directives. This makes us use that instead of the wrapper script. Once the vendored libgit2 is built the 'next' branch can thus also be used with the usual commands `go build`, `go test` without having to use the Makefile or calling the wrapping script. We still can't tell the build tool to build libgit2, so we still need a script for that.

Sign in to join this conversation.

No reviewers