git2go should ensure -DGIT_THREADS was used for libgit2 #329

New Issue

2016-07-26T09:31:01-05:00

hanwen commented

2016-07-26 09:31:01 -05:00

(Migrated from github.com)

It's apparently possible to link libgit2 into a git2go binary, with thread-safety switched off. For git2go this does not make any sense; git2go should crash if libgit2 wasn't compiled with -DGIT_THREADS.

carlosmn commented

2016-07-28 17:59:11 -05:00

(Migrated from github.com)

You would have to choose to build your shared libgit2 without threading support, which would already indicate your choice not to run anything with threads, so I'm not sure how that happens accidentally with anything more-or-less recently.

But yes, that doesn't make a lot of sense with Go. It probably make sense to check for the threading capability and error out (maybe the only option is panic?) if we link against a version without it.

You would have to choose to build your shared libgit2 without threading support, which would already indicate your choice not to run anything with threads, so I'm not sure how that happens accidentally with anything more-or-less recently. But yes, that doesn't make a lot of sense with Go. It probably make sense to check for the threading capability and error out (maybe the only option is panic?) if we link against a version without it.

carlosmn commented

2016-12-23 16:21:31 -06:00

(Migrated from github.com)

Fixed via #354

Sign in to join this conversation.