Remote Refinements #319

Merged
netnose merged 4 commits from remote-refinements into master 2016-10-31 14:04:35 -05:00
netnose commented 2016-05-29 07:59:48 -05:00 (Migrated from github.com)
  • Fixed credentialsCallback return value for missing callback
  • Added Remote Rename
  • Added Remote Disconnect
- Fixed credentialsCallback return value for missing callback - Added Remote Rename - Added Remote Disconnect
carlosmn commented 2016-07-06 17:03:59 -05:00 (Migrated from github.com)

Looks good other than throwing away the errors in rename.

Looks good other than throwing away the errors in rename.
netnose commented 2016-07-07 05:34:14 -05:00 (Migrated from github.com)

You're right, this signature looks better.

You're right, this signature looks better.
carlosmn (Migrated from github.com) reviewed 2016-10-03 04:49:30 -05:00
carlosmn (Migrated from github.com) commented 2016-10-03 04:49:30 -05:00

An error indicates an error in the function, but failure to rename some refspecs because they do not follow the standard pattern is not an error condition. The error array is returned when ret == 0. As the documentation for this function says, the ownership of the strings passes to the caller, so you need to free the string array.

An error indicates an error in the function, but failure to rename some refspecs because they do not follow the standard pattern is not an error condition. The error array is returned when `ret == 0`. As the documentation for this function says, the ownership of the strings passes to the caller, so you need to free the string array.
netnose (Migrated from github.com) reviewed 2016-10-08 04:12:09 -05:00
netnose (Migrated from github.com) commented 2016-10-08 04:12:09 -05:00

The second line of the function frees the string array.

The second line of the function frees the string array.
carlosmn commented 2016-10-31 14:04:39 -05:00 (Migrated from github.com)

Thanks.

Thanks.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#319
No description provided.