Add nil for optional arguments to git_packbuilder_write #31

2013-06-07T18:11:44-05:00

crosbymichael commented

2013-06-07 18:11:44 -05:00

(Migrated from github.com)

The git_packbuilder_write function now takes
two optional arguments used for information
callbacks. These are currently not needed
in the Go wrapper.

Without this patch you cannot build git2go.

The git_packbuilder_write function now takes two optional arguments used for information callbacks. These are currently not needed in the Go wrapper. Without this patch you cannot build git2go.

Merovius commented

2013-06-09 11:56:03 -05:00

(Migrated from github.com)

Better would be, to implement the optional arguments imho.

carlosmn commented

2013-06-09 15:21:02 -05:00

(Migrated from github.com)

The extra arguments are for progress information when you have single-threaded C code, so you don't have to run the packing in a background thread. Luckily in go we don't need this and you can happily run WriteFile in a goroutine and query the progress when you need it.

The extra arguments are for progress information when you have single-threaded C code, so you don't have to run the packing in a background thread. Luckily in go we don't need this and you can happily run `WriteFile` in a goroutine and query the progress when you need it.

crosbymichael commented

2013-06-09 16:02:29 -05:00

(Migrated from github.com)

Yes, I didn't feel like these progress callbacks fit with the go implementation but I would be happy to implement the change if it is required.

carlosmn commented

2013-06-09 18:31:49 -05:00

(Migrated from github.com)

Ah, no; the callback is for the indexing process. Which means we can't ignore it as we have no other way of accessing this.

So this is fine as a compile fix, but we should create a struct for indexer data and create a channel for it here.

Ah, no; the callback is for the indexing process. Which means we can't ignore it as we have no other way of accessing this. So this is fine as a compile fix, but we should create a struct for indexer data and create a channel for it here.

kron4eg commented

2013-06-11 09:47:32 -05:00

(Migrated from github.com)

hehe, I've made same patch :D

vmg commented

2013-06-13 12:12:09 -05:00

(Migrated from github.com)

Thanks!

Sign in to join this conversation.

No reviewers