Make the network code use handles #212

2015-06-10T06:38:44-05:00

carlosmn commented

2015-06-10 06:38:44 -05:00

(Migrated from github.com)

This wasn't ported together with the rest, but it does exhibit the same
issues, so let's port it over now.

This wasn't ported together with the rest, but it does exhibit the same issues, so let's port it over now.

carlosmn commented

2015-06-10 06:40:07 -05:00

(Migrated from github.com)

/cc @michaeledgar @radeksimko this should be enough to get the code in master to work. The code in next requires a somewhat different handling dealing more with the C allocator.

/cc @michaeledgar @radeksimko this should be enough to get the code in `master` to work. The code in `next` requires a somewhat different handling dealing more with the C allocator.

michaeledgar commented

2015-06-18 13:56:10 -05:00

(Migrated from github.com)

This patch is good, and resolves my issues. Thanks!

Sorry it took so long to respond to this - I had a separate bug in my code which presented nearly identically during remote operations. (I was trying to reuse *git.Cred objects, but the underlying *C.git_cred is freed by libgit2 after the first use)

This patch is good, and resolves my issues. Thanks! Sorry it took so long to respond to this - I had a separate bug in my code which presented nearly identically during remote operations. (I was trying to reuse *git.Cred objects, but the underlying *C.git_cred is freed by libgit2 after the first use)

Sign in to join this conversation.

No reviewers