jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Avoid installing script binary to user's $GOPATH/bin. #195

Merged
dmitshur merged 1 commits from next-ignore-script into next 2015-04-21 05:32:35 -05:00
Conversation 2 Commits 1 Files Changed 1 +2
dmitshur commented 2015-04-16 20:51:04 -05:00 (Migrated from github.com)
Copy Link

If I am not mistaken, the script/check-MakeGitError-thread-lock.go is only needed and used in one place:

a4d5118374/Makefile (L7)

It is used in go run script/check-MakeGitError-thread-lock.go.

However, the install target of the same Makefile performs go install ./...:

a4d5118374/Makefile (L11)

Which ends up installing a script binary into user's $GOPATH/bin.

Many people have $GOPATH/bin as part of their $PATH, and if I am correct that script is not needed in any other way except that one place where go run script/check-MakeGitError-thread-lock.go uses it, then it's better to avoid installing the script binary to user's $GOPATH/bin and polluting that (already crowded) namespace.

This PR fixes that. (If I am mistaken, feel free to close the PR.)

If I am not mistaken, the `script/check-MakeGitError-thread-lock.go` is only needed and used in one place: https://github.com/libgit2/git2go/blob/a4d5118374607f107af8063797f62e6a9f7470aa/Makefile#L7 It is used in `go run script/check-MakeGitError-thread-lock.go`. However, the `install` target of the same Makefile performs `go install ./...`: https://github.com/libgit2/git2go/blob/a4d5118374607f107af8063797f62e6a9f7470aa/Makefile#L11 Which ends up installing a `script` binary into user's $GOPATH/bin. Many people have $GOPATH/bin as part of their $PATH, and if I am correct that `script` is not needed in any other way except that one place where `go run script/check-MakeGitError-thread-lock.go` uses it, then it's better to avoid installing the `script` binary to user's $GOPATH/bin and polluting that (already crowded) namespace. This PR fixes that. (If I am mistaken, feel free to close the PR.)
dmitshur commented 2015-04-19 20:27:28 -05:00 (Migrated from github.com)
Copy Link

Any thoughts on this?

Any thoughts on this?
dmitshur commented 2015-04-21 12:46:35 -05:00 (Migrated from github.com)
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#195
No description provided.
Delete Branch "next-ignore-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?