Implement git_repository_discover #19

2013-05-14T14:43:37-05:00

Merovius commented

2013-05-14 14:43:37 -05:00

(Migrated from github.com)

I wrapped git_repository_discover. I decided to expose a string-slice for ceiling_dirs instead of a colon-seperated single string, because it feels more native to go.

vmg commented

2013-05-16 18:38:07 -05:00

(Migrated from github.com)

It doesn't look like your push went through, I double-checked. Can you try again?

Merovius commented

2013-05-16 18:53:33 -05:00

(Migrated from github.com)

I don't know why github is not showing the commit here. When I look at the branch in the webinterface the discover-branch clearly points to a commit doing the right thing. Trying to push only gives a „everything up to date“ which is right.

I would actually suggest to just merge the pull-request if nothing else is wrong - in the worst case we can add the other commit on top of it later. A bugreport to github seems appropriate at least from my vantage-point…

I don't know why github is not showing the commit here. [When I look at the branch in the webinterface](https://github.com/Merovius/git2go/commits/discover) the discover-branch clearly points to [a commit](https://github.com/Merovius/git2go/commit/420cf7f0a650e711e50dc49b3e5faf4a7ceffa0e) doing the right thing. Trying to push only gives a „everything up to date“ which is right. I would actually suggest to just merge the pull-request if nothing else is wrong - in the worst case we can add the other commit on top of it later. A bugreport to github seems appropriate at least from my vantage-point…

vmg commented

2013-05-16 19:41:30 -05:00

(Migrated from github.com)

This is very weird indeed. I'll merge manually and ask somebody from .the .com team to look into the commit issue. :)

Thanks a lot for this!

This is very weird indeed. I'll merge manually and ask somebody from .the .com team to look into the commit issue. :) Thanks a lot for this!

Sign in to join this conversation.

No reviewers