jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Add prune methods to Remote. #165

Merged
calavera merged 1 commits from remote_prune_refs into master 2015-01-09 03:17:55 -06:00
Conversation 3 Commits 1 Files Changed 2 +101 -6
calavera commented 2015-01-05 14:00:32 -06:00 (Migrated from github.com)
Copy Link

@carlosmn, I've noticed that C.git_remote_create doesn't load the prune configuration. I don't know if that's intentional, if not, I have a patch ready for libgit2.

@carlosmn, I've noticed that `C.git_remote_create` doesn't load the prune configuration. I don't know if that's intentional, if not, I have a patch ready for libgit2.
carlosmn commented 2015-01-05 14:13:21 -06:00 (Migrated from github.com)
Copy Link

Aren't we loading it in https://github.com/libgit2/libgit2/blob/master/src/remote.c#L447-L461 ?

Aren't we loading it in https://github.com/libgit2/libgit2/blob/master/src/remote.c#L447-L461 ?
calavera commented 2015-01-05 14:16:06 -06:00 (Migrated from github.com)
Copy Link

Yes, but that's only if you call C.git_remote_lookup. The remote pointer returned by C.git_remote_create doesn't call those lines. Let me open a PR in libgit2 to keep the conversation there.

Yes, but that's only if you call `C.git_remote_lookup`. The `remote` pointer returned by `C.git_remote_create` doesn't call those lines. Let me open a PR in libgit2 to keep the conversation there.
calavera commented 2015-01-06 09:06:19 -06:00 (Migrated from github.com)
Copy Link

I think this is ready to merge. The changes in libgit2 don't really block this new addition.

I think this is ready to merge. The changes in libgit2 don't really block this new addition.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#165
No description provided.
Delete Branch "remote_prune_refs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?