Address issue #108 #109

2014-08-18T19:39:20-05:00

bnavetta commented

2014-08-18 19:39:20 -05:00

(Migrated from github.com)

This should address most of #108. I haven't added tests yet, and it doesn't cover the entire status API, but I should be able to add those soon.

carlosmn commented

2014-08-25 09:04:55 -05:00

(Migrated from github.com)

I'd rather avoid having the foreach functions wrapped. They introduce more complexity and they don't actually do anything that you can't ByIndex. If you want the convenience of an automatically-selected path, this can be done in Go much more safely.

I'd rather avoid having the foreach functions wrapped. They introduce more complexity and they don't actually do anything that you can't `ByIndex`. If you want the convenience of an automatically-selected path, this can be done in Go much more safely.

carlosmn commented

2014-09-10 09:42:30 -05:00

(Migrated from github.com)

Did you want to add more tests? Otherwise I think I'll just merge it. The functionality itself is tested in libgit2 itself, so we should be able to get away with some testing that just makes sure the data conversion is working.

bnavetta commented

2014-09-10 14:12:26 -05:00

(Migrated from github.com)

I think the existing tests cover all the basic functionality. The StatusList parts seem to be fine, and the tests should handle data conversion, since they pass in options and check the resulting entries. Thanks!

I think the existing tests cover all the basic functionality. The `StatusList` parts seem to be fine, and the tests should handle data conversion, since they pass in options and check the resulting entries. Thanks!

Sign in to join this conversation.

No reviewers