From e969b33b335f0cf797a7c21ac14ddcbdf8aedce3 Mon Sep 17 00:00:00 2001 From: David Calavera Date: Mon, 27 Oct 2014 08:32:50 -0700 Subject: [PATCH] Make filtering logic more simple. --- remote.go | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/remote.go b/remote.go index a3b4c6c..e360fc0 100644 --- a/remote.go +++ b/remote.go @@ -607,21 +607,18 @@ func (o *Remote) Ls(filterRefs ...string) ([]RemoteHead, error) { var heads []RemoteHead - if len(filterRefs) > 0 { - for _, s := range goSlice { - head := newRemoteHeadFromC(s) + for _, s := range goSlice { + head := newRemoteHeadFromC(s) + if len(filterRefs) > 0 { for _, r := range filterRefs { if strings.Contains(head.Name, r) { heads = append(heads, head) break } } - } - } else { - heads = make([]RemoteHead, size) - for i, s := range goSlice { - heads[i] = newRemoteHeadFromC(s) + } else { + heads = append(heads, head) } }