From e69f00381364628e1c89db141d3eb8dfc27ec99a Mon Sep 17 00:00:00 2001 From: Segev Finer Date: Fri, 13 Nov 2020 16:52:55 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: lhchavez --- reference.go | 3 --- reference_test.go | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/reference.go b/reference.go index 672945f..701fb07 100644 --- a/reference.go +++ b/reference.go @@ -504,9 +504,6 @@ const ( // characters and collapsing runs of adjacent slashes between name components // into a single slash. // -// Once normalized, if the reference name is valid, it will be returned in the -// user allocated buffer. -// // See git_reference_symbolic_create() for rules about valid names. func ReferenceNormalizeName(name string, flags ReferenceFormat) (string, error) { cname := C.CString(name) diff --git a/reference_test.go b/reference_test.go index 691d17d..0b02f55 100644 --- a/reference_test.go +++ b/reference_test.go @@ -231,7 +231,7 @@ func TestReferenceNormalizeName(t *testing.T) { checkFatal(t, err) if ref != "refs/heads/master" { - t.Errorf("refs/heads//master should be normalized correctly") + t.Errorf("ReferenceNormalizeName(%q) = %q; want %q", "refs/heads//master", ref, want) } ref, err = ReferenceNormalizeName("master", ReferenceFormatAllowOnelevel|ReferenceFormatRefspecShorthand)