From 97d05a1e4c1202f3acd579773f7c7ca457413661 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= Date: Thu, 3 Jan 2019 23:53:13 +0000 Subject: [PATCH] Merge pull request #432 from josharian/simplify-oid git: simplify some Oid methods (cherry picked from commit c740e1d83df805f55eda80c76bd1f1c562b3051d) --- git.go | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/git.go b/git.go index 0925e45..897d261 100644 --- a/git.go +++ b/git.go @@ -189,22 +189,16 @@ func (oid *Oid) Cmp(oid2 *Oid) int { } func (oid *Oid) Copy() *Oid { - ret := new(Oid) - copy(ret[:], oid[:]) - return ret + ret := *oid + return &ret } func (oid *Oid) Equal(oid2 *Oid) bool { - return bytes.Equal(oid[:], oid2[:]) + return *oid == *oid2 } func (oid *Oid) IsZero() bool { - for _, a := range oid { - if a != 0 { - return false - } - } - return true + return *oid == Oid{} } func (oid *Oid) NCmp(oid2 *Oid, n uint) int {