jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

fix: Use `err` instead of error as a variable name for errors (#746) (#749) 

fix #745

(cherry picked from commit f6c5753df8)

Co-authored-by: Suhaib Mujahid <suhaibmujahid@gmail.com>
This commit is contained in:
github-actions[bot] 2021-02-15 13:57:38 -08:00 committed by GitHub
parent bbb77f1bdf
commit 6f19ef8843
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
git.go
View File

@ -196,9 +196,9 @@ func NewOid(s string) (*Oid, error) {
o := new(Oid) o := new(Oid)
slice, error := hex.DecodeString(s) slice, err := hex.DecodeString(s)
if error != nil { if err != nil {
return nil, error return nil, err
} }
if len(slice) != 20 { if len(slice) != 20 {

38
odb_test.go
View File

@ -61,31 +61,31 @@ func TestOdbStream(t *testing.T) {
_, _ = seedTestRepo(t, repo) _, _ = seedTestRepo(t, repo)
odb, error := repo.Odb() odb, err := repo.Odb()
checkFatal(t, error) checkFatal(t, err)
str := "hello, world!" str := "hello, world!"
writeStream, error := odb.NewWriteStream(int64(len(str)), ObjectBlob) writeStream, err := odb.NewWriteStream(int64(len(str)), ObjectBlob)
checkFatal(t, error) checkFatal(t, err)
n, error := io.WriteString(writeStream, str) n, err := io.WriteString(writeStream, str)
checkFatal(t, error) checkFatal(t, err)
if n != len(str) { if n != len(str) {
t.Fatalf("Bad write length %v != %v", n, len(str)) t.Fatalf("Bad write length %v != %v", n, len(str))
} }
error = writeStream.Close() err = writeStream.Close()
checkFatal(t, error) checkFatal(t, err)
expectedId, error := NewOid("30f51a3fba5274d53522d0f19748456974647b4f") expectedId, err := NewOid("30f51a3fba5274d53522d0f19748456974647b4f")
checkFatal(t, error) checkFatal(t, err)
if writeStream.Id.Cmp(expectedId) != 0 { if writeStream.Id.Cmp(expectedId) != 0 {
t.Fatal("Wrong data written") t.Fatal("Wrong data written")
} }
readStream, error := odb.NewReadStream(&writeStream.Id) readStream, err := odb.NewReadStream(&writeStream.Id)
checkFatal(t, error) checkFatal(t, err)
data, error := ioutil.ReadAll(readStream) data, err := ioutil.ReadAll(readStream)
if str != string(data) { if str != string(data) {
t.Fatalf("Wrong data read %v != %v", str, string(data)) t.Fatalf("Wrong data read %v != %v", str, string(data))
} }
@ -98,8 +98,8 @@ func TestOdbHash(t *testing.T) {
_, _ = seedTestRepo(t, repo) _, _ = seedTestRepo(t, repo)
odb, error := repo.Odb() odb, err := repo.Odb()
checkFatal(t, error) checkFatal(t, err)
str := `tree 115fcae49287c82eb55bb275cbbd4556fbed72b7 str := `tree 115fcae49287c82eb55bb275cbbd4556fbed72b7
parent 66e1c476199ebcd3e304659992233132c5a52c6c parent 66e1c476199ebcd3e304659992233132c5a52c6c
@ -109,11 +109,11 @@ committer John Doe <john@doe.com> 1390682018 +0000
Initial commit.` Initial commit.`
for _, data := range [][]byte{[]byte(str), doublePointerBytes()} { for _, data := range [][]byte{[]byte(str), doublePointerBytes()} {
oid, error := odb.Hash(data, ObjectCommit) oid, err := odb.Hash(data, ObjectCommit)
checkFatal(t, error) checkFatal(t, err)
coid, error := odb.Write(data, ObjectCommit) coid, err := odb.Write(data, ObjectCommit)
checkFatal(t, error) checkFatal(t, err)
if oid.Cmp(coid) != 0 { if oid.Cmp(coid) != 0 {
t.Fatal("Hash and write Oids are different") t.Fatal("Hash and write Oids are different")