Oid: use Go's conversion functions
Go already has all the necessary pieces for encoding and decoding hex strings. Using them let's us avoid going into C land. Benchmarks show this takes about half the time as using libgit2's functions.
This commit is contained in:
parent
c243c31f7d
commit
0bb73e43a8
24
git.go
24
git.go
|
@ -8,6 +8,7 @@ package git
|
|||
import "C"
|
||||
import (
|
||||
"bytes"
|
||||
"encoding/hex"
|
||||
"errors"
|
||||
"runtime"
|
||||
"strings"
|
||||
|
@ -52,24 +53,23 @@ func (oid *Oid) toC() *C.git_oid {
|
|||
}
|
||||
|
||||
func NewOid(s string) (*Oid, error) {
|
||||
o := new(Oid)
|
||||
cs := C.CString(s)
|
||||
defer C.free(unsafe.Pointer(cs))
|
||||
|
||||
runtime.LockOSThread()
|
||||
defer runtime.UnlockOSThread()
|
||||
|
||||
if ret := C.git_oid_fromstr(o.toC(), cs); ret < 0 {
|
||||
return nil, MakeGitError(ret)
|
||||
if len(s) > C.GIT_OID_HEXSZ {
|
||||
return nil, errors.New("string is too long for oid")
|
||||
}
|
||||
|
||||
o := new(Oid)
|
||||
|
||||
slice, error := hex.DecodeString(s)
|
||||
if error != nil {
|
||||
return nil, error
|
||||
}
|
||||
|
||||
copy(o[:], slice[:20])
|
||||
return o, nil
|
||||
}
|
||||
|
||||
func (oid *Oid) String() string {
|
||||
buf := make([]byte, 40)
|
||||
C.git_oid_fmt((*C.char)(unsafe.Pointer(&buf[0])), oid.toC())
|
||||
return string(buf)
|
||||
return hex.EncodeToString(oid[:])
|
||||
}
|
||||
|
||||
func (oid *Oid) Cmp(oid2 *Oid) int {
|
||||
|
|
Loading…
Reference in New Issue