From f34ac6272cae99eef745cf22249d8e87a50f4341 Mon Sep 17 00:00:00 2001
From: Brandon Keiji <brandonkeiji@google.com>
Date: Fri, 25 Apr 2025 02:53:59 +0000
Subject: [PATCH] fix: install rsync in publish pipeline (#166)

---
 .gcp/dogfood.yaml         | 20 +++++++++++-------
 .gcp/publish-dry-run.yaml | 44 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+), 7 deletions(-)
 create mode 100644 .gcp/publish-dry-run.yaml

diff --git a/.gcp/dogfood.yaml b/.gcp/dogfood.yaml
index 3c42bbb9..8e74a581 100644
--- a/.gcp/dogfood.yaml
+++ b/.gcp/dogfood.yaml
@@ -1,11 +1,11 @@
 steps:
   # Install dependencies
-  - name: 'node'
+  - name: 'node:bookworm'
     entrypoint: 'npm'
     args: ['install']
 
   # Run prerelease versioning script across workspaces with dynamic version
-  - name: 'node'
+  - name: 'node:bookworm'
     entrypoint: 'npm'
     args:
       [
@@ -17,19 +17,25 @@ steps:
       ]
 
   # Run prerelease dependency script across workspaces
-  - name: 'node'
+  - name: 'node:bookworm'
     entrypoint: 'npm'
     args: ['run', 'prerelease:deps', '--workspaces']
 
   # Authenticate with our registry
-  - name: 'node'
+  - name: 'node:bookworm'
     entrypoint: 'npm'
     args: ['run', 'auth']
 
   # Publish packages from workspaces with 'dogfood' tag
-  - name: 'node'
-    entrypoint: 'npm'
-    args: ['publish', '--tag=head', '--workspaces']
+  # we awkwardly need to install rsync beforehand. TODO: use a dedicated dev container
+  - name: 'node:bookworm'
+    entrypoint: 'bash'
+    args:
+      - '-c'
+      - |
+        apt-get update -y
+        apt-get install -y rsync
+        npm publish --tag=head --workspaces
 
 options:
   defaultLogsBucketBehavior: REGIONAL_USER_OWNED_BUCKET
diff --git a/.gcp/publish-dry-run.yaml b/.gcp/publish-dry-run.yaml
new file mode 100644
index 00000000..4f10fe5f
--- /dev/null
+++ b/.gcp/publish-dry-run.yaml
@@ -0,0 +1,44 @@
+steps:
+  # Install dependencies
+  - name: 'ubuntu'
+    entrypoint: 'bash'
+    args: ['-c', 'apt-get', 'install', '-y', 'rsync']
+  - name: 'node'
+    entrypoint: 'npm'
+    args: ['install']
+
+  # Run prerelease versioning script across workspaces with dynamic version
+  - name: 'node'
+    entrypoint: 'npm'
+    args:
+      [
+        'run',
+        'prerelease:version',
+        '--workspaces',
+        '--',
+        '--suffix="$SHORT_SHA.$_REVISION"',
+      ]
+
+  # Run prerelease dependency script across workspaces
+  - name: 'node'
+    entrypoint: 'npm'
+    args: ['run', 'prerelease:deps', '--workspaces']
+
+  # Authenticate with our registry
+  - name: 'node'
+    entrypoint: 'npm'
+    args: ['run', 'auth']
+
+  # Dry run publish to make sure that's not broken
+  # we awkwardly need to install rsync beforehand. TODO: use a dedicated dev container
+  - name: 'node:bookworm'
+    entrypoint: 'bash'
+    args:
+      - '-c'
+      - |
+        apt-get update -y
+        apt-get install -y rsync
+        npm publish --dry-run --tag=head --workspaces
+
+options:
+  defaultLogsBucketBehavior: REGIONAL_USER_OWNED_BUCKET