From f19b9ed4f8444ff766338b1a16f58a05522b3ce1 Mon Sep 17 00:00:00 2001 From: owenofbrien <86964623+owenofbrien@users.noreply.github.com> Date: Mon, 30 Jun 2025 17:51:17 -0500 Subject: [PATCH] Removed fallback logic for gaia id logging (#2761) --- packages/core/src/utils/user_id.test.ts | 6 ++---- packages/core/src/utils/user_id.ts | 5 ++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/core/src/utils/user_id.test.ts b/packages/core/src/utils/user_id.test.ts index 81b99ef4..5d9c72e4 100644 --- a/packages/core/src/utils/user_id.test.ts +++ b/packages/core/src/utils/user_id.test.ts @@ -28,21 +28,19 @@ describe('user_id', () => { expect(result).toBeDefined(); expect(typeof result).toBe('string'); - expect(result.length).toBeGreaterThan(0); // Should be consistent on subsequent calls const secondCall = getObfuscatedGoogleAccountId(); expect(secondCall).toBe(result); }); - it('should return the same as installation ID when no Google Account ID is cached', () => { + it('should return empty string when no Google Account ID is cached', () => { // In a clean test environment, there should be no cached Google Account ID // so getObfuscatedGoogleAccountId should fall back to installation ID const googleAccountIdResult = getObfuscatedGoogleAccountId(); - const installationIdResult = getInstallationId(); // They should be the same when no Google Account ID is cached - expect(googleAccountIdResult).toBe(installationIdResult); + expect(googleAccountIdResult).toBe(''); }); }); }); diff --git a/packages/core/src/utils/user_id.ts b/packages/core/src/utils/user_id.ts index 4f17bf96..5238fc3c 100644 --- a/packages/core/src/utils/user_id.ts +++ b/packages/core/src/utils/user_id.ts @@ -73,9 +73,8 @@ export function getObfuscatedGoogleAccountId(): string { return googleAccountId; } } catch (_error) { - // If there's any error accessing Google Account ID, fall back to installation ID + // If there's any error accessing Google Account ID, just return empty string } - // Fall back to installation ID when no Google Account ID is cached or on error - return getInstallationId(); + return ''; }