jcarr
/
gemini-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: use for...of loop instead of traditional for loop (#1840)

This commit is contained in:
Noritaka Kobayashi 2025-06-29 17:53:09 +09:00 committed by GitHub
parent fc21d1cae3
commit e188daab91
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/cli/src/ui/hooks/slashCommandProcessor.ts
View File

@ -401,8 +401,8 @@ export const useSlashCommandProcessor = (
const descLines = server.description.trim().split('\n');
if (descLines) {
message += ':\n';
for (let i = 0; i < descLines.length; i++) {
message += ` ${greenColor}${descLines[i]}${resetColor}\n`;
for (const descLine of descLines) {
message += ` ${greenColor}${descLine}${resetColor}\n`;
}
} else {
message += '\n';
@ -431,8 +431,8 @@ export const useSlashCommandProcessor = (
const descLines = tool.description.trim().split('\n');
if (descLines) {
message += ':\n';
for (let i = 0; i < descLines.length; i++) {
message += ` ${greenColor}${descLines[i]}${resetColor}\n`;
for (const descLine of descLines) {
message += ` ${greenColor}${descLine}${resetColor}\n`;
}
} else {
message += '\n';
@ -457,8 +457,8 @@ export const useSlashCommandProcessor = (
.trim()
.split('\n');
if (paramsLines) {
for (let i = 0; i < paramsLines.length; i++) {
message += ` ${greenColor}${paramsLines[i]}${resetColor}\n`;
for (const paramsLine of paramsLines) {
message += ` ${greenColor}${paramsLine}${resetColor}\n`;
}
}
}
@ -561,8 +561,8 @@ export const useSlashCommandProcessor = (
// If there are multiple lines, add proper indentation for each line
if (descLines) {
for (let i = 0; i < descLines.length; i++) {
message += ` ${greenColor}${descLines[i]}${resetColor}\n`;
for (const descLine of descLines) {
message += ` ${greenColor}${descLine}${resetColor}\n`;
}
}
} else {

4
packages/cli/src/ui/utils/textUtils.ts
View File

@ -34,10 +34,10 @@ export function isBinary(
const sample = data.length > sampleSize ? data.subarray(0, sampleSize) : data;
for (let i = 0; i < sample.length; i++) {
for (const byte of sample) {
// The presence of a NULL byte (0x00) is one of the most reliable
// indicators of a binary file. Text files should not contain them.
if (sample[i] === 0) {
if (byte === 0) {
return true;
}
}