jcarr
/
gemini-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Correct pluralization of the number of occurrences in `EditTool` tool errors (#2463)

This commit is contained in:
Tim Rogers 2025-06-29 20:53:59 +01:00 committed by GitHub
parent 0cfaeedf03
commit dbe63e7234
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/src/tools/edit.test.ts
View File

@ -486,10 +486,10 @@ describe('EditTool', () => {
// The default mockEnsureCorrectEdit will return 2 occurrences for 'old' // The default mockEnsureCorrectEdit will return 2 occurrences for 'old'
const result = await tool.execute(params, new AbortController().signal); const result = await tool.execute(params, new AbortController().signal);
expect(result.llmContent).toMatch( expect(result.llmContent).toMatch(
/Expected 1 occurrences but found 2 for old_string in file/, /Expected 1 occurrence but found 2 for old_string in file/,
); );
expect(result.returnDisplay).toMatch( expect(result.returnDisplay).toMatch(
/Failed to edit, expected 1 occurrence\(s\) but found 2/, /Failed to edit, expected 1 occurrence but found 2/,
); );
}); });
@ -532,7 +532,7 @@ describe('EditTool', () => {
/Expected 3 occurrences but found 2 for old_string in file/, /Expected 3 occurrences but found 2 for old_string in file/,
); );
expect(result.returnDisplay).toMatch( expect(result.returnDisplay).toMatch(
/Failed to edit, expected 3 occurrence\(s\) but found 2/, /Failed to edit, expected 3 occurrences but found 2/,
); );
}); });

7
packages/core/src/tools/edit.ts
View File

@ -257,9 +257,12 @@ Expectation for required parameters:
raw: `Failed to edit, 0 occurrences found for old_string in ${params.file_path}. No edits made. The exact text in old_string was not found. Ensure you're not escaping content incorrectly and check whitespace, indentation, and context. Use ${ReadFileTool.Name} tool to verify.`, raw: `Failed to edit, 0 occurrences found for old_string in ${params.file_path}. No edits made. The exact text in old_string was not found. Ensure you're not escaping content incorrectly and check whitespace, indentation, and context. Use ${ReadFileTool.Name} tool to verify.`,
}; };
} else if (occurrences !== expectedReplacements) { } else if (occurrences !== expectedReplacements) {
const occurenceTerm =
expectedReplacements === 1 ? 'occurrence' : 'occurrences';
error = { error = {
display: `Failed to edit, expected ${expectedReplacements} occurrence(s) but found ${occurrences}.`, display: `Failed to edit, expected ${expectedReplacements} ${occurenceTerm} but found ${occurrences}.`,
raw: `Failed to edit, Expected ${expectedReplacements} occurrences but found ${occurrences} for old_string in file: ${params.file_path}`, raw: `Failed to edit, Expected ${expectedReplacements} ${occurenceTerm} but found ${occurrences} for old_string in file: ${params.file_path}`,
}; };
} }
} else { } else {