remove enable editor flag (#984)
This commit is contained in:
parent
a9e56ee460
commit
ad2e47dc20
|
@ -195,7 +195,6 @@ export async function loadCliConfig(
|
|||
fileFilteringRespectGitIgnore: settings.fileFiltering?.respectGitIgnore,
|
||||
fileFilteringAllowBuildArtifacts:
|
||||
settings.fileFiltering?.allowBuildArtifacts,
|
||||
enableModifyWithExternalEditors: settings.enableModifyWithExternalEditors,
|
||||
checkpoint: argv.checkpoint,
|
||||
});
|
||||
}
|
||||
|
|
|
@ -38,7 +38,6 @@ export interface Settings {
|
|||
contextFileName?: string;
|
||||
accessibility?: AccessibilitySettings;
|
||||
telemetry?: boolean;
|
||||
enableModifyWithExternalEditors?: boolean;
|
||||
preferredEditor?: string;
|
||||
|
||||
// Git-aware file filtering settings
|
||||
|
|
|
@ -28,7 +28,7 @@ export interface ToolConfirmationMessageProps {
|
|||
|
||||
export const ToolConfirmationMessage: React.FC<
|
||||
ToolConfirmationMessageProps
|
||||
> = ({ confirmationDetails, config, isFocused = true }) => {
|
||||
> = ({ confirmationDetails, isFocused = true }) => {
|
||||
const { onConfirm } = confirmationDetails;
|
||||
|
||||
useInput((_, key) => {
|
||||
|
@ -85,18 +85,12 @@ export const ToolConfirmationMessage: React.FC<
|
|||
label: 'Yes, allow always',
|
||||
value: ToolConfirmationOutcome.ProceedAlways,
|
||||
},
|
||||
);
|
||||
|
||||
const externalEditorsEnabled =
|
||||
config?.getEnableModifyWithExternalEditors() ?? false;
|
||||
if (externalEditorsEnabled) {
|
||||
options.push({
|
||||
{
|
||||
label: 'Modify with external editor',
|
||||
value: ToolConfirmationOutcome.ModifyWithEditor,
|
||||
});
|
||||
}
|
||||
|
||||
options.push({ label: 'No (esc)', value: ToolConfirmationOutcome.Cancel });
|
||||
},
|
||||
{ label: 'No (esc)', value: ToolConfirmationOutcome.Cancel },
|
||||
);
|
||||
} else if (confirmationDetails.type === 'exec') {
|
||||
const executionProps =
|
||||
confirmationDetails as ToolExecuteConfirmationDetails;
|
||||
|
|
|
@ -81,7 +81,6 @@ export interface ConfigParameters {
|
|||
telemetryLogUserPromptsEnabled?: boolean;
|
||||
fileFilteringRespectGitIgnore?: boolean;
|
||||
fileFilteringAllowBuildArtifacts?: boolean;
|
||||
enableModifyWithExternalEditors?: boolean;
|
||||
checkpoint?: boolean;
|
||||
}
|
||||
|
||||
|
@ -113,7 +112,6 @@ export class Config {
|
|||
private readonly geminiIgnorePatterns: string[] = [];
|
||||
private readonly fileFilteringRespectGitIgnore: boolean;
|
||||
private readonly fileFilteringAllowBuildArtifacts: boolean;
|
||||
private readonly enableModifyWithExternalEditors: boolean;
|
||||
private fileDiscoveryService: FileDiscoveryService | null = null;
|
||||
private gitService: GitService | undefined = undefined;
|
||||
private readonly checkpoint: boolean;
|
||||
|
@ -147,8 +145,6 @@ export class Config {
|
|||
params.fileFilteringRespectGitIgnore ?? true;
|
||||
this.fileFilteringAllowBuildArtifacts =
|
||||
params.fileFilteringAllowBuildArtifacts ?? false;
|
||||
this.enableModifyWithExternalEditors =
|
||||
params.enableModifyWithExternalEditors ?? false;
|
||||
this.checkpoint = params.checkpoint ?? false;
|
||||
|
||||
if (params.contextFileName) {
|
||||
|
@ -297,10 +293,6 @@ export class Config {
|
|||
return this.fileFilteringAllowBuildArtifacts;
|
||||
}
|
||||
|
||||
getEnableModifyWithExternalEditors(): boolean {
|
||||
return this.enableModifyWithExternalEditors;
|
||||
}
|
||||
|
||||
getCheckpointEnabled(): boolean {
|
||||
return this.checkpoint;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue