jcarr
/
gemini-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix excessive console logging + remove unnecessary try catch (#5860)

This commit is contained in:
Shreya Keshive 2025-08-08 17:48:02 -04:00 committed by GitHub
parent 344ee29f77
commit 9ac62565a0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/cli/src/ui/commands/ideCommand.ts
View File

@ -83,15 +83,10 @@ async function getIdeStatusMessageWithFiles(ideClient: IdeClient): Promise<{
switch (connection.status) {
case IDEConnectionStatus.Connected: {
let content = `🟢 Connected to ${ideClient.getDetectedIdeDisplayName()}`;
try {
const context = await ideContext.getIdeContext();
const openFiles = context?.workspaceState?.openFiles;
if (openFiles && openFiles.length > 0) {
content += formatFileList(openFiles);
}
} catch (_e) {
// Ignore
const context = ideContext.getIdeContext();
const openFiles = context?.workspaceState?.openFiles;
if (openFiles && openFiles.length > 0) {
content += formatFileList(openFiles);
}
return {
messageType: 'info',

10
packages/core/src/ide/ide-client.ts
View File

@ -211,16 +211,16 @@ export class IdeClient {
this.state.status === IDEConnectionStatus.Disconnected &&
status === IDEConnectionStatus.Disconnected;
// Only update details if the state wasn't already disconnected, so that
// the first detail message is preserved.
// Only update details & log to console if the state wasn't already
// disconnected, so that the first detail message is preserved.
if (!isAlreadyDisconnected) {
this.state = { status, details };
}
if (status === IDEConnectionStatus.Disconnected) {
if (logToConsole) {
logger.error(details);
}
}
if (status === IDEConnectionStatus.Disconnected) {
logger.debug(details);
ideContext.clearIdeContext();
}