jcarr
/
gemini-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused attribute (#6661)

This commit is contained in:
Tommaso Sciortino 2025-08-20 16:13:50 -07:00 committed by GitHub
parent 0193ce77dd
commit 653267a64f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/cli/src/ui/hooks/useToolScheduler.test.ts
View File

@ -194,7 +194,6 @@ describe('useReactToolScheduler in YOLO Mode', () => {
(mockToolRequiresConfirmation.execute as Mock).mockResolvedValue({ (mockToolRequiresConfirmation.execute as Mock).mockResolvedValue({
llmContent: expectedOutput, llmContent: expectedOutput,
returnDisplay: 'YOLO Formatted tool output', returnDisplay: 'YOLO Formatted tool output',
summary: 'YOLO summary',
} as ToolResult); } as ToolResult);
const { result } = renderSchedulerInYoloMode(); const { result } = renderSchedulerInYoloMode();
@ -352,7 +351,6 @@ describe('useReactToolScheduler', () => {
(mockTool.execute as Mock).mockResolvedValue({ (mockTool.execute as Mock).mockResolvedValue({
llmContent: 'Tool output', llmContent: 'Tool output',
returnDisplay: 'Formatted tool output', returnDisplay: 'Formatted tool output',
summary: 'Formatted summary',
} as ToolResult); } as ToolResult);
(mockTool.shouldConfirmExecute as Mock).mockResolvedValue(null); (mockTool.shouldConfirmExecute as Mock).mockResolvedValue(null);
@ -517,7 +515,6 @@ describe('useReactToolScheduler', () => {
(mockToolRequiresConfirmation.execute as Mock).mockResolvedValue({ (mockToolRequiresConfirmation.execute as Mock).mockResolvedValue({
llmContent: expectedOutput, llmContent: expectedOutput,
returnDisplay: 'Confirmed display', returnDisplay: 'Confirmed display',
summary: 'Confirmed summary',
} as ToolResult); } as ToolResult);
const { result } = renderScheduler(); const { result } = renderScheduler();
@ -684,7 +681,6 @@ describe('useReactToolScheduler', () => {
resolveExecutePromise({ resolveExecutePromise({
llmContent: 'Final output', llmContent: 'Final output',
returnDisplay: 'Final display', returnDisplay: 'Final display',
summary: 'Final summary',
} as ToolResult); } as ToolResult);
}); });
await act(async () => { await act(async () => {
@ -718,7 +714,6 @@ describe('useReactToolScheduler', () => {
tool1.execute.mockResolvedValue({ tool1.execute.mockResolvedValue({
llmContent: 'Output 1', llmContent: 'Output 1',
returnDisplay: 'Display 1', returnDisplay: 'Display 1',
summary: 'Summary 1',
} as ToolResult); } as ToolResult);
tool1.shouldConfirmExecute.mockResolvedValue(null); tool1.shouldConfirmExecute.mockResolvedValue(null);
@ -726,7 +721,6 @@ describe('useReactToolScheduler', () => {
tool2.execute.mockResolvedValue({ tool2.execute.mockResolvedValue({
llmContent: 'Output 2', llmContent: 'Output 2',
returnDisplay: 'Display 2', returnDisplay: 'Display 2',
summary: 'Summary 2',
} as ToolResult); } as ToolResult);
tool2.shouldConfirmExecute.mockResolvedValue(null); tool2.shouldConfirmExecute.mockResolvedValue(null);
@ -809,7 +803,6 @@ describe('useReactToolScheduler', () => {
resolve({ resolve({
llmContent: 'done', llmContent: 'done',
returnDisplay: 'done display', returnDisplay: 'done display',
summary: 'done summary',
}), }),
50, 50,
), ),

1
packages/core/src/tools/tools.test.ts
View File

@ -101,7 +101,6 @@ describe('DeclarativeTool', () => {
const successResult: ToolResult = { const successResult: ToolResult = {
llmContent: 'Success!', llmContent: 'Success!',
returnDisplay: 'Success!', returnDisplay: 'Success!',
summary: 'Tool executed successfully',
}; };
const executeFn = vi.fn().mockResolvedValue(successResult); const executeFn = vi.fn().mockResolvedValue(successResult);
const invocation = new TestToolInvocation({}, executeFn); const invocation = new TestToolInvocation({}, executeFn);

5
packages/core/src/tools/tools.ts
View File

@ -308,11 +308,6 @@ export abstract class BaseDeclarativeTool<
export type AnyDeclarativeTool = DeclarativeTool<object, ToolResult>; export type AnyDeclarativeTool = DeclarativeTool<object, ToolResult>;
export interface ToolResult { export interface ToolResult {
/**
* A short, one-line summary of the tool's action and result.
* e.g., "Read 5 files", "Wrote 256 bytes to foo.txt"
*/
summary?: string;
/** /**
* Content meant to be included in LLM history. * Content meant to be included in LLM history.
* This should represent the factual outcome of the tool execution. * This should represent the factual outcome of the tool execution.