From 5c759d48c7e49b84f35544478d86cfe60a41b569 Mon Sep 17 00:00:00 2001 From: Tommaso Sciortino Date: Tue, 8 Jul 2025 09:30:49 -0700 Subject: [PATCH] Don't enforce leading slash since that's not true on Windows (#3545) --- packages/core/src/tools/read-file.test.ts | 6 +++--- packages/core/src/tools/read-file.ts | 1 - 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/core/src/tools/read-file.test.ts b/packages/core/src/tools/read-file.test.ts index e7ff822f..96bb7680 100644 --- a/packages/core/src/tools/read-file.test.ts +++ b/packages/core/src/tools/read-file.test.ts @@ -74,7 +74,7 @@ describe('ReadFileTool', () => { it('should return error for relative path', () => { const params: ReadFileToolParams = { absolute_path: 'test.txt' }; expect(tool.validateToolParams(params)).toBe( - `params/absolute_path must match pattern "^/"`, + `File path must be absolute, but was relative: test.txt. You must provide an absolute path.`, ); }); @@ -144,10 +144,10 @@ describe('ReadFileTool', () => { const params: ReadFileToolParams = { absolute_path: 'relative/path.txt' }; const result = await tool.execute(params, abortSignal); expect(result.llmContent).toBe( - 'Error: Invalid parameters provided. Reason: params/absolute_path must match pattern "^/"', + 'Error: Invalid parameters provided. Reason: File path must be absolute, but was relative: relative/path.txt. You must provide an absolute path.', ); expect(result.returnDisplay).toBe( - 'params/absolute_path must match pattern "^/"', + 'File path must be absolute, but was relative: relative/path.txt. You must provide an absolute path.', ); }); diff --git a/packages/core/src/tools/read-file.ts b/packages/core/src/tools/read-file.ts index a26f50ce..dd173813 100644 --- a/packages/core/src/tools/read-file.ts +++ b/packages/core/src/tools/read-file.ts @@ -60,7 +60,6 @@ export class ReadFileTool extends BaseTool { description: "The absolute path to the file to read (e.g., '/home/user/project/file.txt'). Relative paths are not supported. You must provide an absolute path.", type: Type.STRING, - pattern: '^/', }, offset: { description: