fix: forward entire tool call confirmation object through useToolScheduler (#481)

packages/cli/src/ui/components/messages/ToolConfirmationMessage.tsx

@@ -10,7 +10,6 @@ import { DiffRenderer } from './DiffRenderer.js';
 import { Colors } from '../../colors.js';
 import {
   ToolCallConfirmationDetails,
-  ToolEditConfirmationDetails,
   ToolConfirmationOutcome,
   ToolExecuteConfirmationDetails,
 } from '@gemini-code/server';
@@ -23,12 +22,6 @@ export interface ToolConfirmationMessageProps {
   confirmationDetails: ToolCallConfirmationDetails;
 }
 
-function isEditDetails(
-  props: ToolCallConfirmationDetails,
-): props is ToolEditConfirmationDetails {
-  return (props as ToolEditConfirmationDetails).fileName !== undefined;
-}
-
 export const ToolConfirmationMessage: React.FC<
   ToolConfirmationMessageProps
 > = ({ confirmationDetails }) => {
@@ -49,7 +42,7 @@ export const ToolConfirmationMessage: React.FC<
     RadioSelectItem<ToolConfirmationOutcome>
   >();
 
-  if (isEditDetails(confirmationDetails)) {
+  if (confirmationDetails.type === 'edit') {
     // Body content is now the DiffRenderer, passing filename to it
     // The bordered box is removed from here and handled within DiffRenderer
     bodyContent = (

packages/cli/src/ui/hooks/useToolScheduler.ts

@@ -10,6 +10,7 @@ import {
   ToolCallResponseInfo,
   ToolConfirmationOutcome,
   Tool,
+  ToolCallConfirmationDetails,
 } from '@gemini-code/server';
 import { Part } from '@google/genai';
 import { useCallback, useEffect, useState } from 'react';
@@ -55,7 +56,7 @@ type WaitingToolCall = {
   status: 'awaiting_approval';
   request: ToolCallRequestInfo;
   tool: Tool;
-  confirm: (outcome: ToolConfirmationOutcome) => Promise<void>;
+  confirmationDetails: ToolCallConfirmationDetails;
 };
 
 export type Status = ToolCall['status'];
@@ -119,17 +120,20 @@ export function useToolScheduler(
               status: 'awaiting_approval',
               request: r,
               tool,
-              confirm: async (outcome) => {
+              confirmationDetails: {
-                await userApproval.onConfirm(outcome);
+                ...userApproval,
-                setToolCalls(
+                onConfirm: async (outcome) => {
-                  outcome === ToolConfirmationOutcome.Cancel
+                  await userApproval.onConfirm(outcome);
-                    ? setStatus(
+                  setToolCalls(
-                        r.callId,
+                    outcome === ToolConfirmationOutcome.Cancel
-                        'cancelled',
+                      ? setStatus(
-                        'User did not allow tool call',
+                          r.callId,
-                      )
+                          'cancelled',
-                    : setStatus(r.callId, 'scheduled'),
+                          'User did not allow tool call',
-                );
+                        )
+                      : setStatus(r.callId, 'scheduled'),
+                  );
+                },
               },
             };
           }
@@ -249,7 +253,7 @@ function setStatus(
 function setStatus(
   targetCallId: string,
   status: 'awaiting_approval',
-  confirm: (t: ToolConfirmationOutcome) => Promise<void>,
+  confirm: ToolCallConfirmationDetails,
 ): (t: ToolCall[]) => ToolCall[];
 function setStatus(
   targetCallId: string,
@@ -296,9 +300,7 @@ function setStatus(
           const next: WaitingToolCall = {
             ...t,
             status: 'awaiting_approval',
-            confirm: auxiliaryData as (
+            confirmationDetails: auxiliaryData as ToolCallConfirmationDetails,
-              o: ToolConfirmationOutcome,
-            ) => Promise<void>,
           };
           return next;
         }
@@ -426,10 +428,7 @@ export function mapToDisplay(
           description: t.tool.getDescription(t.request.args),
           resultDisplay: undefined,
           status: mapStatus(t.status),
-          confirmationDetails: {
+          confirmationDetails: t.confirmationDetails,
-            title: t.request.name,
-            onConfirm: t.confirm,
-          },
         };
       case 'executing':
         return {

packages/server/src/tools/edit.ts

@@ -291,6 +291,7 @@ Expectation for parameters:
       { context: 3 },
     );
     const confirmationDetails: ToolEditConfirmationDetails = {
+      type: 'edit',
       title: `Confirm Edit: ${shortenPath(makeRelative(params.file_path, this.rootDirectory))}`,
       fileName,
       fileDiff,

packages/server/src/tools/shell.ts

@@ -107,6 +107,7 @@ export class ShellTool extends BaseTool<ShellToolParams, ToolResult> {
       return false; // already approved and whitelisted
     }
     const confirmationDetails: ToolExecuteConfirmationDetails = {
+      type: 'exec',
       title: 'Confirm Shell Command',
       command: params.command,
       rootCommand,

packages/server/src/tools/tools.ts

@@ -171,25 +171,23 @@ export interface FileDiff {
   fileName: string;
 }
 
-export interface ToolCallConfirmationDetailsDefault {
+export interface ToolEditConfirmationDetails {
+  type: 'edit';
   title: string;
   onConfirm: (outcome: ToolConfirmationOutcome) => Promise<void>;
-}
-
-export interface ToolEditConfirmationDetails
-  extends ToolCallConfirmationDetailsDefault {
   fileName: string;
   fileDiff: string;
 }
 
-export interface ToolExecuteConfirmationDetails
+export interface ToolExecuteConfirmationDetails {
-  extends ToolCallConfirmationDetailsDefault {
+  type: 'exec';
+  title: string;
+  onConfirm: (outcome: ToolConfirmationOutcome) => Promise<void>;
   command: string;
   rootCommand: string;
 }
 
 export type ToolCallConfirmationDetails =
-  | ToolCallConfirmationDetailsDefault
   | ToolEditConfirmationDetails
   | ToolExecuteConfirmationDetails;
 

packages/server/src/tools/write-file.ts

@@ -158,6 +158,7 @@ export class WriteFileTool extends BaseTool<WriteFileToolParams, ToolResult> {
     );
 
     const confirmationDetails: ToolEditConfirmationDetails = {
+      type: 'edit',
       title: `Confirm Write: ${shortenPath(relativePath)}`,
       fileName,
       fileDiff,

packages/server/src/utils/nextSpeakerChecker.ts

@@ -94,7 +94,7 @@ export async function checkNextSpeaker(
     return null;
   } catch (error) {
     console.warn(
-      'Failed to talk to Gemiin endpoint when seeing if conversation should continue.',
+      'Failed to talk to Gemini endpoint when seeing if conversation should continue.',
       error,
     );
     return null;