Prevent hard crashing on update notifier fail. (#1254)

This commit is contained in:
N. Taylor Mullen 2025-06-20 00:30:30 -07:00 committed by GitHub
parent 787c319e87
commit 4d9e258a1e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 26 additions and 21 deletions

View File

@ -9,27 +9,32 @@ import { readPackageUp } from 'read-package-up';
import process from 'node:process';
export async function checkForUpdates(): Promise<string | null> {
// read-package-up looks for the closest package.json from cwd
const pkgResult = await readPackageUp({ cwd: process.cwd() });
if (!pkgResult) {
try {
// read-package-up looks for the closest package.json from cwd
const pkgResult = await readPackageUp({ cwd: process.cwd() });
if (!pkgResult) {
return null;
}
const { packageJson } = pkgResult;
const notifier = updateNotifier({
pkg: {
name: packageJson.name,
version: packageJson.version,
},
// check every time
updateCheckInterval: 0,
// allow notifier to run in scripts
shouldNotifyInNpmScript: true,
});
if (notifier.update) {
return `Gemini CLI update available! ${notifier.update.current}${notifier.update.latest}\nRun npm install -g ${packageJson.name} to update`;
}
return null;
} catch (e) {
console.warn('Failed to check for updates: ' + e);
return null;
}
const { packageJson } = pkgResult;
const notifier = updateNotifier({
pkg: {
name: packageJson.name,
version: packageJson.version,
},
// check every time
updateCheckInterval: 0,
// allow notifier to run in scripts
shouldNotifyInNpmScript: true,
});
if (notifier.update) {
return `Gemini CLI update available! ${notifier.update.current}${notifier.update.latest}\nRun npm install -g ${packageJson.name} to update`;
}
return null;
}