From 431a312d4d4d8686e1009eef3c9a02032ccfd356 Mon Sep 17 00:00:00 2001 From: Jerop Kipruto Date: Wed, 13 Aug 2025 10:38:45 +0900 Subject: [PATCH] Show OpenTelemetry SDK initialization & shutdown in debug mode only (#6096) --- packages/cli/src/nonInteractiveCli.ts | 2 +- packages/core/src/telemetry/sdk.ts | 18 +++++++++++++----- packages/core/src/telemetry/telemetry.test.ts | 4 ++-- 3 files changed, 16 insertions(+), 8 deletions(-) diff --git a/packages/cli/src/nonInteractiveCli.ts b/packages/cli/src/nonInteractiveCli.ts index 95ed70cf..c237e56b 100644 --- a/packages/cli/src/nonInteractiveCli.ts +++ b/packages/cli/src/nonInteractiveCli.ts @@ -143,7 +143,7 @@ export async function runNonInteractive( } finally { consolePatcher.cleanup(); if (isTelemetrySdkInitialized()) { - await shutdownTelemetry(); + await shutdownTelemetry(config); } } } diff --git a/packages/core/src/telemetry/sdk.ts b/packages/core/src/telemetry/sdk.ts index 1167750a..c6630236 100644 --- a/packages/core/src/telemetry/sdk.ts +++ b/packages/core/src/telemetry/sdk.ts @@ -125,25 +125,33 @@ export function initializeTelemetry(config: Config): void { try { sdk.start(); - console.log('OpenTelemetry SDK started successfully.'); + if (config.getDebugMode()) { + console.log('OpenTelemetry SDK started successfully.'); + } telemetryInitialized = true; initializeMetrics(config); } catch (error) { console.error('Error starting OpenTelemetry SDK:', error); } - process.on('SIGTERM', shutdownTelemetry); - process.on('SIGINT', shutdownTelemetry); + process.on('SIGTERM', () => { + shutdownTelemetry(config); + }); + process.on('SIGINT', () => { + shutdownTelemetry(config); + }); } -export async function shutdownTelemetry(): Promise { +export async function shutdownTelemetry(config: Config): Promise { if (!telemetryInitialized || !sdk) { return; } try { ClearcutLogger.getInstance()?.shutdown(); await sdk.shutdown(); - console.log('OpenTelemetry SDK shut down successfully.'); + if (config.getDebugMode()) { + console.log('OpenTelemetry SDK shut down successfully.'); + } } catch (error) { console.error('Error shutting down SDK:', error); } finally { diff --git a/packages/core/src/telemetry/telemetry.test.ts b/packages/core/src/telemetry/telemetry.test.ts index 9734e382..15bd2e95 100644 --- a/packages/core/src/telemetry/telemetry.test.ts +++ b/packages/core/src/telemetry/telemetry.test.ts @@ -45,7 +45,7 @@ describe('telemetry', () => { afterEach(async () => { // Ensure we shut down telemetry even if a test fails. if (isTelemetrySdkInitialized()) { - await shutdownTelemetry(); + await shutdownTelemetry(mockConfig); } }); @@ -57,7 +57,7 @@ describe('telemetry', () => { it('should shutdown the telemetry service', async () => { initializeTelemetry(mockConfig); - await shutdownTelemetry(); + await shutdownTelemetry(mockConfig); expect(mockNodeSdk.shutdown).toHaveBeenCalled(); });