jcarr
/
gemini-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix typo in RFC 9728 impl (#5126)

This commit is contained in:
Tommaso Sciortino 2025-07-29 16:03:39 -07:00 committed by GitHub
parent 008051e42d
commit 327f915610
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/core/src/mcp/oauth-utils.test.ts
View File

@ -140,7 +140,7 @@ describe('OAuthUtils', () => {
describe('parseWWWAuthenticateHeader', () => { describe('parseWWWAuthenticateHeader', () => {
it('should parse resource metadata URI from WWW-Authenticate header', () => { it('should parse resource metadata URI from WWW-Authenticate header', () => {
const header = const header =
'Bearer realm="example", resource_metadata_uri="https://example.com/.well-known/oauth-protected-resource"'; 'Bearer realm="example", resource_metadata="https://example.com/.well-known/oauth-protected-resource"';
const result = OAuthUtils.parseWWWAuthenticateHeader(header); const result = OAuthUtils.parseWWWAuthenticateHeader(header);
expect(result).toBe( expect(result).toBe(
'https://example.com/.well-known/oauth-protected-resource', 'https://example.com/.well-known/oauth-protected-resource',

4
packages/core/src/mcp/oauth-utils.ts
View File

@ -198,8 +198,8 @@ export class OAuthUtils {
* @returns The resource metadata URI if found * @returns The resource metadata URI if found
*/ */
static parseWWWAuthenticateHeader(header: string): string | null { static parseWWWAuthenticateHeader(header: string): string | null {
// Parse Bearer realm and resource_metadata_uri // Parse Bearer realm and resource_metadata
const match = header.match(/resource_metadata_uri="([^"]+)"/); const match = header.match(/resource_metadata="([^"]+)"/);
if (match) { if (match) {
return match[1]; return match[1];
} }

14
packages/core/src/tools/mcp-client.ts
View File

@ -145,20 +145,6 @@ export function getMCPDiscoveryState(): MCPDiscoveryState {
return mcpDiscoveryState; return mcpDiscoveryState;
} }
/**
* Parse www-authenticate header to extract OAuth metadata URI.
*
* @param wwwAuthenticate The www-authenticate header value
* @returns The resource metadata URI if found, null otherwise
*/
function _parseWWWAuthenticate(wwwAuthenticate: string): string | null {
// Parse header like: Bearer realm="MCP Server", resource_metadata_uri="https://..."
const resourceMetadataMatch = wwwAuthenticate.match(
/resource_metadata_uri="([^"]+)"/,
);
return resourceMetadataMatch ? resourceMetadataMatch[1] : null;
}
/** /**
* Extract WWW-Authenticate header from error message string. * Extract WWW-Authenticate header from error message string.
* This is a more robust approach than regex matching. * This is a more robust approach than regex matching.