From 221b0669000b8292795267cbf71a95ad39c5fb08 Mon Sep 17 00:00:00 2001 From: Noritaka Kobayashi Date: Sat, 28 Jun 2025 10:14:59 +0900 Subject: [PATCH] chore: fix typo in mcp-client (#1555) Co-authored-by: Scott Densmore --- packages/core/src/tools/mcp-client.test.ts | 22 +++++++++++----------- packages/core/src/tools/mcp-client.ts | 10 +++++----- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/packages/core/src/tools/mcp-client.test.ts b/packages/core/src/tools/mcp-client.test.ts index c9546ba3..f963a060 100644 --- a/packages/core/src/tools/mcp-client.test.ts +++ b/packages/core/src/tools/mcp-client.test.ts @@ -14,7 +14,7 @@ import { afterEach, Mocked, } from 'vitest'; -import { discoverMcpTools, sanatizeParameters } from './mcp-client.js'; +import { discoverMcpTools, sanitizeParameters } from './mcp-client.js'; import { Schema, Type } from '@google/genai'; import { Config, MCPServerConfig } from '../config/config.js'; import { DiscoveredMCPTool } from './mcp-tool.js'; @@ -538,10 +538,10 @@ describe('discoverMcpTools', () => { }); }); -describe('sanatizeParameters', () => { +describe('sanitizeParameters', () => { it('should do nothing for an undefined schema', () => { const schema = undefined; - sanatizeParameters(schema); + sanitizeParameters(schema); }); it('should remove default when anyOf is present', () => { @@ -549,11 +549,11 @@ describe('sanatizeParameters', () => { anyOf: [{ type: Type.STRING }, { type: Type.NUMBER }], default: 'hello', }; - sanatizeParameters(schema); + sanitizeParameters(schema); expect(schema.default).toBeUndefined(); }); - it('should recursively sanatize items in anyOf', () => { + it('should recursively sanitize items in anyOf', () => { const schema: Schema = { anyOf: [ { @@ -563,22 +563,22 @@ describe('sanatizeParameters', () => { { type: Type.NUMBER }, ], }; - sanatizeParameters(schema); + sanitizeParameters(schema); expect(schema.anyOf![0].default).toBeUndefined(); }); - it('should recursively sanatize items in items', () => { + it('should recursively sanitize items in items', () => { const schema: Schema = { items: { anyOf: [{ type: Type.STRING }], default: 'world', }, }; - sanatizeParameters(schema); + sanitizeParameters(schema); expect(schema.items!.default).toBeUndefined(); }); - it('should recursively sanatize items in properties', () => { + it('should recursively sanitize items in properties', () => { const schema: Schema = { properties: { prop1: { @@ -587,7 +587,7 @@ describe('sanatizeParameters', () => { }, }, }; - sanatizeParameters(schema); + sanitizeParameters(schema); expect(schema.properties!.prop1.default).toBeUndefined(); }); @@ -614,7 +614,7 @@ describe('sanatizeParameters', () => { }, }, }; - sanatizeParameters(schema); + sanitizeParameters(schema); expect(schema.properties!.prop1.items!.default).toBeUndefined(); const nestedProp = schema.properties!.prop2.anyOf![0].properties!.nestedProp; diff --git a/packages/core/src/tools/mcp-client.ts b/packages/core/src/tools/mcp-client.ts index ceedb068..72382ac1 100644 --- a/packages/core/src/tools/mcp-client.ts +++ b/packages/core/src/tools/mcp-client.ts @@ -304,7 +304,7 @@ async function connectAndDiscover( toolNameForModel.slice(0, 28) + '___' + toolNameForModel.slice(-32); } - sanatizeParameters(funcDecl.parameters); + sanitizeParameters(funcDecl.parameters); // Ensure parameters is a valid JSON schema object, default to empty if not. const parameterSchema: Record = @@ -362,7 +362,7 @@ async function connectAndDiscover( } } -export function sanatizeParameters(schema?: Schema) { +export function sanitizeParameters(schema?: Schema) { if (!schema) { return; } @@ -370,15 +370,15 @@ export function sanatizeParameters(schema?: Schema) { // Vertex AI gets confused if both anyOf and default are set. schema.default = undefined; for (const item of schema.anyOf) { - sanatizeParameters(item); + sanitizeParameters(item); } } if (schema.items) { - sanatizeParameters(schema.items); + sanitizeParameters(schema.items); } if (schema.properties) { for (const item of Object.values(schema.properties)) { - sanatizeParameters(item); + sanitizeParameters(item); } } }