jcarr
/
gemini-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Disable automatic image building if BUILD_SANDBOX is not provided (#764)

This commit is contained in:
Tolik Malibroda 2025-06-05 18:47:39 +02:00 committed by GitHub
parent 4d4cf0f2f9
commit 1d20cedf03
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/cli/configuration.md
View File

@ -77,7 +77,7 @@ When you create a `.gemini/settings.json` file for project-specific settings, or
- See the [Theming section in README.md](../../README.md#theming) for available theme names. - See the [Theming section in README.md](../../README.md#theming) for available theme names.
- **`sandbox`** (boolean or string): - **`sandbox`** (boolean or string):
- Controls whether and how to use sandboxing for tool execution. - Controls whether and how to use sandboxing for tool execution.
- If a `.gemini/sandbox.Dockerfile` exists in your project, it will be used to build a custom sandbox image based on `gemini-cli-sandbox`. - If a `.gemini/sandbox.Dockerfile` exists in your project, it will be used to build a custom sandbox image.
- `true`: Enable default sandbox (see [README](../../README.md) for behavior). - `true`: Enable default sandbox (see [README](../../README.md) for behavior).
- `false`: Disable sandboxing (WARNING: this is inherently unsafe). - `false`: Disable sandboxing (WARNING: this is inherently unsafe).
- `"docker"` or `"podman"`: Explicitly choose container-based sandboxing command. - `"docker"` or `"podman"`: Explicitly choose container-based sandboxing command.
@ -289,7 +289,7 @@ Sandboxing is disabled by default, but you can enable it in a few ways:
By default, it uses a pre-built `gemini-cli-sandbox` Docker image. By default, it uses a pre-built `gemini-cli-sandbox` Docker image.
For project-specific sandboxing needs, you can create a custom Dockerfile at `.gemini/sandbox.Dockerfile` in your project's root directory. This Dockerfile should be based on the base sandbox image: For project-specific sandboxing needs, you can create a custom Dockerfile at `.gemini/sandbox.Dockerfile` in your project's root directory. This Dockerfile can be based on the base sandbox image:
```dockerfile ```dockerfile
FROM gemini-cli-sandbox FROM gemini-cli-sandbox
@ -300,7 +300,11 @@ FROM gemini-cli-sandbox
# COPY ./my-config /app/my-config # COPY ./my-config /app/my-config
``` ```
When `.gemini/sandbox.Dockerfile` exists, the CLI will automatically build and use a custom image for your project. When `.gemini/sandbox.Dockerfile` exists, you can use `BUILD_SANDBOX` environment variable when running Gemini CLI to automatically build the custom sandbox image:
```bash
BUILD_SANDBOX=1 gemini -s
```
## Theming ## Theming

5
packages/cli/src/utils/sandbox.ts
View File

@ -285,11 +285,10 @@ export async function start_sandbox(sandbox: string) {
const image = await getSandboxImageName(isCustomProjectSandbox); const image = await getSandboxImageName(isCustomProjectSandbox);
const workdir = process.cwd(); const workdir = process.cwd();
// if BUILD_SANDBOX is set or project-specific sandbox.Dockerfile provided, // if BUILD_SANDBOX is set, then call scripts/build_sandbox.sh under gemini-cli repo
// then call scripts/build_sandbox.sh under gemini-cli repo
// //
// note this can only be done with binary linked from gemini-cli repo // note this can only be done with binary linked from gemini-cli repo
if (process.env.BUILD_SANDBOX || isCustomProjectSandbox) { if (process.env.BUILD_SANDBOX) {
if (!gcPath.includes('gemini-cli/packages/')) { if (!gcPath.includes('gemini-cli/packages/')) {
console.error( console.error(
'ERROR: cannot build sandbox using installed gemini binary; ' + 'ERROR: cannot build sandbox using installed gemini binary; ' +