From 10b52ac4e89b434e4c63ecd12b741755dfc774a4 Mon Sep 17 00:00:00 2001 From: Tommaso Sciortino Date: Sat, 7 Jun 2025 13:39:53 -0700 Subject: [PATCH] Fix missing arg warning in tests (#820) --- packages/cli/src/config/config.test.ts | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/cli/src/config/config.test.ts b/packages/cli/src/config/config.test.ts index f3ced43e..802cf588 100644 --- a/packages/cli/src/config/config.test.ts +++ b/packages/cli/src/config/config.test.ts @@ -83,28 +83,28 @@ describe('loadCliConfig', () => { it('should set showMemoryUsage to true when --memory flag is present', async () => { process.argv = ['node', 'script.js', '--show_memory_usage']; const settings: Settings = {}; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getShowMemoryUsage()).toBe(true); }); it('should set showMemoryUsage to false when --memory flag is not present', async () => { process.argv = ['node', 'script.js']; const settings: Settings = {}; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getShowMemoryUsage()).toBe(false); }); it('should set showMemoryUsage to false by default from settings if CLI flag is not present', async () => { process.argv = ['node', 'script.js']; const settings: Settings = { showMemoryUsage: false }; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getShowMemoryUsage()).toBe(false); }); it('should prioritize CLI flag over settings for showMemoryUsage (CLI true, settings false)', async () => { process.argv = ['node', 'script.js', '--show_memory_usage']; const settings: Settings = { showMemoryUsage: false }; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getShowMemoryUsage()).toBe(true); }); }); @@ -128,49 +128,49 @@ describe('loadCliConfig telemetry', () => { it('should set telemetry to false by default when no flag or setting is present', async () => { process.argv = ['node', 'script.js']; const settings: Settings = {}; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getTelemetry()).toBe(false); }); it('should set telemetry to true when --telemetry flag is present', async () => { process.argv = ['node', 'script.js', '--telemetry']; const settings: Settings = {}; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getTelemetry()).toBe(true); }); it('should set telemetry to false when --no-telemetry flag is present', async () => { process.argv = ['node', 'script.js', '--no-telemetry']; const settings: Settings = {}; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getTelemetry()).toBe(false); }); it('should use telemetry value from settings if CLI flag is not present (settings true)', async () => { process.argv = ['node', 'script.js']; const settings: Settings = { telemetry: true }; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getTelemetry()).toBe(true); }); it('should use telemetry value from settings if CLI flag is not present (settings false)', async () => { process.argv = ['node', 'script.js']; const settings: Settings = { telemetry: false }; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getTelemetry()).toBe(false); }); it('should prioritize --telemetry CLI flag (true) over settings (false)', async () => { process.argv = ['node', 'script.js', '--telemetry']; const settings: Settings = { telemetry: false }; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getTelemetry()).toBe(true); }); it('should prioritize --no-telemetry CLI flag (false) over settings (true)', async () => { process.argv = ['node', 'script.js', '--no-telemetry']; const settings: Settings = { telemetry: true }; - const config = await loadCliConfig(settings); + const config = await loadCliConfig(settings, []); expect(config.getTelemetry()).toBe(false); }); });