jcarr
/
gemini-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix stats display layout (#6758)

This commit is contained in:
christine betts 2025-08-21 17:56:18 +00:00 committed by GitHub
parent a90ca626d3
commit 0a7879272d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 19 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/cli/src/ui/components/StatsDisplay.tsx
View File

@ -31,7 +31,8 @@ const StatRow: React.FC<StatRowProps> = ({ title, children }) => (
<Box width={28}> <Box width={28}>
<Text color={theme.text.link}>{title}</Text> <Text color={theme.text.link}>{title}</Text>
</Box> </Box>
{children} {/* FIX: Wrap children in a Box that can grow to fill remaining space */}
<Box flexGrow={1}>{children}</Box>
</Box> </Box>
); );
@ -47,7 +48,8 @@ const SubStatRow: React.FC<SubStatRowProps> = ({ title, children }) => (
<Box width={26}> <Box width={26}>
<Text>» {title}</Text> <Text>» {title}</Text>
</Box> </Box>
{children} {/* FIX: Apply the same flexGrow fix here */}
<Box flexGrow={1}>{children}</Box>
</Box> </Box>
); );
@ -204,8 +206,8 @@ export const StatsDisplay: React.FC<StatsDisplayProps> = ({
<StatRow title="Tool Calls:"> <StatRow title="Tool Calls:">
<Text> <Text>
{tools.totalCalls} ({' '} {tools.totalCalls} ({' '}
<Text color={theme.status.success}>✔ {tools.totalSuccess}</Text>{' '} <Text color={theme.status.success}>✓ {tools.totalSuccess}</Text>{' '}
<Text color={theme.status.error}>✖ {tools.totalFail}</Text> ) <Text color={theme.status.error}>x {tools.totalFail}</Text> )
</Text> </Text>
</StatRow> </StatRow>
<StatRow title="Success Rate:"> <StatRow title="Success Rate:">

2
packages/cli/src/ui/components/__snapshots__/SessionSummaryDisplay.test.tsx.snap
View File

@ -7,7 +7,7 @@ exports[`<SessionSummaryDisplay /> > renders the summary display with a title 1`
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: │ │ Session ID: │
│ Tool Calls: 0 ( ✔ 0 ✖ 0 ) │ │ Tool Calls: 0 ( ✓ 0 x 0 ) │
│ Success Rate: 0.0% │ │ Success Rate: 0.0% │
│ Code Changes: +42 -15 │ │ Code Changes: +42 -15 │
│ │ │ │

24
packages/cli/src/ui/components/__snapshots__/StatsDisplay.test.tsx.snap
View File

@ -7,7 +7,7 @@ exports[`<StatsDisplay /> > Code Changes Display > displays Code Changes when li
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 1 ( ✔ 1 ✖ 0 ) │ │ Tool Calls: 1 ( ✓ 1 x 0 ) │
│ Success Rate: 100.0% │ │ Success Rate: 100.0% │
│ Code Changes: +42 -18 │ │ Code Changes: +42 -18 │
│ │ │ │
@ -28,7 +28,7 @@ exports[`<StatsDisplay /> > Code Changes Display > hides Code Changes when no li
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 1 ( ✔ 1 ✖ 0 ) │ │ Tool Calls: 1 ( ✓ 1 x 0 ) │
│ Success Rate: 100.0% │ │ Success Rate: 100.0% │
│ │ │ │
│ Performance │ │ Performance │
@ -48,7 +48,7 @@ exports[`<StatsDisplay /> > Conditional Color Tests > renders success rate in gr
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 10 ( ✔ 10 ✖ 0 ) │ │ Tool Calls: 10 ( ✓ 10 x 0 ) │
│ Success Rate: 100.0% │ │ Success Rate: 100.0% │
│ │ │ │
│ Performance │ │ Performance │
@ -68,7 +68,7 @@ exports[`<StatsDisplay /> > Conditional Color Tests > renders success rate in re
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 10 ( ✔ 5 ✖ 5 ) │ │ Tool Calls: 10 ( ✓ 5 x 5 ) │
│ Success Rate: 50.0% │ │ Success Rate: 50.0% │
│ │ │ │
│ Performance │ │ Performance │
@ -88,7 +88,7 @@ exports[`<StatsDisplay /> > Conditional Color Tests > renders success rate in ye
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 10 ( ✔ 9 ✖ 1 ) │ │ Tool Calls: 10 ( ✓ 9 x 1 ) │
│ Success Rate: 90.0% │ │ Success Rate: 90.0% │
│ │ │ │
│ Performance │ │ Performance │
@ -108,7 +108,7 @@ exports[`<StatsDisplay /> > Conditional Rendering Tests > hides Efficiency secti
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 0 ( ✔ 0 ✖ 0 ) │ │ Tool Calls: 0 ( ✓ 0 x 0 ) │
│ Success Rate: 0.0% │ │ Success Rate: 0.0% │
│ │ │ │
│ Performance │ │ Performance │
@ -132,7 +132,7 @@ exports[`<StatsDisplay /> > Conditional Rendering Tests > hides User Agreement w
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 2 ( ✔ 1 ✖ 1 ) │ │ Tool Calls: 2 ( ✓ 1 x 1 ) │
│ Success Rate: 50.0% │ │ Success Rate: 50.0% │
│ │ │ │
│ Performance │ │ Performance │
@ -152,7 +152,7 @@ exports[`<StatsDisplay /> > Title Rendering > renders the custom title when a ti
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 0 ( ✔ 0 ✖ 0 ) │ │ Tool Calls: 0 ( ✓ 0 x 0 ) │
│ Success Rate: 0.0% │ │ Success Rate: 0.0% │
│ │ │ │
│ Performance │ │ Performance │
@ -172,7 +172,7 @@ exports[`<StatsDisplay /> > Title Rendering > renders the default title when no
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 0 ( ✔ 0 ✖ 0 ) │ │ Tool Calls: 0 ( ✓ 0 x 0 ) │
│ Success Rate: 0.0% │ │ Success Rate: 0.0% │
│ │ │ │
│ Performance │ │ Performance │
@ -192,7 +192,7 @@ exports[`<StatsDisplay /> > renders a table with two models correctly 1`] = `
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 0 ( ✔ 0 ✖ 0 ) │ │ Tool Calls: 0 ( ✓ 0 x 0 ) │
│ Success Rate: 0.0% │ │ Success Rate: 0.0% │
│ │ │ │
│ Performance │ │ Performance │
@ -221,7 +221,7 @@ exports[`<StatsDisplay /> > renders all sections when all data is present 1`] =
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 2 ( ✔ 1 ✖ 1 ) │ │ Tool Calls: 2 ( ✓ 1 x 1 ) │
│ Success Rate: 50.0% │ │ Success Rate: 50.0% │
│ User Agreement: 100.0% (1 reviewed) │ │ User Agreement: 100.0% (1 reviewed) │
│ │ │ │
@ -250,7 +250,7 @@ exports[`<StatsDisplay /> > renders only the Performance section in its zero sta
│ │ │ │
│ Interaction Summary │ │ Interaction Summary │
│ Session ID: test-session-id │ │ Session ID: test-session-id │
│ Tool Calls: 0 ( ✔ 0 ✖ 0 ) │ │ Tool Calls: 0 ( ✓ 0 x 0 ) │
│ Success Rate: 0.0% │ │ Success Rate: 0.0% │
│ │ │ │
│ Performance │ │ Performance │