jcarr
/
coriolis
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Correct a security check in PyHurricane.h. 

* Bug: In Hurricane, in PyHurricane.h, the macro GENERIC_METHOD_HEAD was
    not checking at all that the underlying Hurricane object was not NULL.
    This may have lead to core-dumps.
This commit is contained in:
Jean-Paul Chaput 2016-04-13 18:30:45 +02:00
parent b46c06042b
commit 506ccbd589
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
hurricane/src/isobar/hurricane/isobar/PyHurricane.h
View File

@ -194,13 +194,13 @@ extern "C" {
#define GENERIC_METHOD_HEAD(SELF_TYPE,SELF_OBJECT,function) \ #define GENERIC_METHOD_HEAD(SELF_TYPE,SELF_OBJECT,function) \
if ( self->ACCESS_OBJECT == NULL ) { \ if ( self->ACCESS_OBJECT == NULL ) { \
PyErr_SetString ( ProxyError, "Attempt to call " function " on an unbound hurricane object" ); \ PyErr_SetString( ProxyError, "Attempt to call " function " on an unbound hurricane object" ); \
return ( NULL ); \ return NULL; \
} \ } \
SELF_TYPE* SELF_OBJECT = dynamic_cast<SELF_TYPE*>(self->ACCESS_OBJECT);\ SELF_TYPE* SELF_OBJECT = dynamic_cast<SELF_TYPE*>(self->ACCESS_OBJECT);\
if ( self->ACCESS_OBJECT == NULL ) { \ if ( SELF_OBJECT == NULL ) { \
PyErr_SetString ( ProxyError, "Invalid dynamic_cast while calling " function "" ); \ PyErr_SetString( ProxyError, "Invalid dynamic_cast<> while calling " function "" ); \
return ( NULL ); \ return NULL; \
} }