From 09192ba08420f5053886c93add06dae43bdd3747 Mon Sep 17 00:00:00 2001
From: Jean-Paul Chaput <Jean-Paul.Chaput@lip6.fr>
Date: Tue, 9 Jun 2020 14:08:08 +0200
Subject: [PATCH] Bug fix, check for unconnected signals in
 CRL::VectorPortMap::toVhdlportMap().

* Bug: In CRL::VectorPortmap::toVhdlPortMap(), unconnected bits where
    correctly checkeds for multi-bits vectors (both ordered and holed),
    but not for mono-bits connections (ONE bit of a vector).
---
 .../src/ccore/alliance/vst/VhdlPortMap.cpp    | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/crlcore/src/ccore/alliance/vst/VhdlPortMap.cpp b/crlcore/src/ccore/alliance/vst/VhdlPortMap.cpp
index 43b6c86a..2cd91314 100644
--- a/crlcore/src/ccore/alliance/vst/VhdlPortMap.cpp
+++ b/crlcore/src/ccore/alliance/vst/VhdlPortMap.cpp
@@ -77,14 +77,13 @@ namespace Vhdl {
   PortMap* PortMap::create ( const Signal* signal, unsigned int flags )
   {
     const ScalarSignal* scalarSignal = dynamic_cast<const ScalarSignal*>( signal );
-    if (not scalarSignal) {
-      const VectorSignal* vectorSignal = dynamic_cast<const VectorSignal*>( signal );
-      if (vectorSignal)
-        return new VectorPortMap ( vectorSignal, flags );
-      else
-        throw Error( "PortMap::create() Unable to cast toward <ScalarSignal> or <VectorSignal>." );
-    }
-    return new ScalarPortMap ( scalarSignal, flags );
+    if (scalarSignal) return new ScalarPortMap ( scalarSignal, flags );
+
+    const VectorSignal* vectorSignal = dynamic_cast<const VectorSignal*>( signal );
+    if (not vectorSignal)
+      throw Error( "PortMap::create() Unable to cast toward <ScalarSignal> or <VectorSignal>." );
+
+    return new VectorPortMap ( vectorSignal, flags );
   }
 
 
@@ -243,16 +242,22 @@ namespace Vhdl {
         first = false;
       }
     } else {
+      const Bit* bit  = NULL;
+      string     name = "UNCONNECTED";
+
       // cerr << "VhdlPortMap is in bit mode for \"" << _signal->getName() << "\""
       //      << " _flags:" << _flags << " mappedNames:" << _mapping.size() << endl;
 
       auto imapping  = _mapping.rbegin();
       bool first = true;
       for ( ; imapping!=_mapping.rend() ; ++imapping ) {
+        bit  = imapping ->second;
+        name = (bit) ? bit ->getSignal()->getName() : "UNCONNECTED";
+
         if (not first) out << "\n" << tab << "         , ";
         
         out << setw(width) << left << _signal->getBit(imapping->first)->getName()
-            << " => " << imapping->second->getName();
+            << " => " << name;
         first = false;
       }
     }