interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Compare commits

merge into: interesting:riscv
Branches Tags
interesting:riscv
interesting:examine_unavailable_harts_rebase
interesting:examine_unavailable_harts_squash
interesting:examine_unavailable_harts
interesting:examine_unavailable_harts_backup
interesting:reset_test
interesting:us_xds110
interesting:hypervisor_translate
interesting:dsp5680_build
interesting:examine_command
interesting:halt_examine
interesting:gd32vf103
interesting:set_group
interesting:macro
interesting:s2_increment
interesting:jlink
interesting:buf_sget
interesting:static
interesting:global
interesting:dmstatus_version
interesting:manual_hwbp
interesting:regcache
interesting:vector2
interesting:busy
interesting:mem64
interesting:bscan_optimization
interesting:debug-log-reg-failure
interesting:reverse-resume-order
interesting:new_bscan_approach
interesting:bscan_tunnel
interesting:log_output
interesting:haltreq
interesting:deinit
interesting:eclipse_memory_read
interesting:old_fixes_and_eclipse_memory_read
interesting:mpsse_flush
interesting:sba_tests
interesting:riscv-compliance
interesting:wip
interesting:riscv-compliance-dev
interesting:compliance_dev
interesting:fence_i_fix_for_release
interesting:rbb_cleanup
interesting:dmi_read
interesting:add_macos_build
interesting:fix_macbuild
interesting:update_defines
interesting:macbuild
interesting:winbuild
interesting:eclipse_multicore_fix
interesting:FE_402_fix
interesting:gdb_next_port
interesting:print_port
interesting:build32
interesting:travis-nop
interesting:old_triggers
interesting:master
interesting:autoconf
interesting:gitignore-build
interesting:multicore
interesting:release
interesting:race
interesting:nohartstatus
interesting:newprogram
interesting:__archive__
interesting:latest
interesting:openocd64-ad4c3e1
interesting:openocd64-8b80fe1
interesting:openocd64-41b9c69e92d9660cb2eff508f3bc8218a3b3e461
interesting:openocd64-d486b21
interesting:v2018.12.0
interesting:v20181030
interesting:v20180928
interesting:v20180629
interesting:v20171231
interesting:v20170818
interesting:v20170621
interesting:v20170612
interesting:v20170608
...
pull from: interesting:halt_examine
Branches Tags
interesting:riscv
interesting:examine_unavailable_harts_rebase
interesting:examine_unavailable_harts_squash
interesting:examine_unavailable_harts
interesting:examine_unavailable_harts_backup
interesting:reset_test
interesting:us_xds110
interesting:hypervisor_translate
interesting:dsp5680_build
interesting:examine_command
interesting:halt_examine
interesting:gd32vf103
interesting:set_group
interesting:macro
interesting:s2_increment
interesting:jlink
interesting:buf_sget
interesting:static
interesting:global
interesting:dmstatus_version
interesting:manual_hwbp
interesting:regcache
interesting:vector2
interesting:busy
interesting:mem64
interesting:bscan_optimization
interesting:debug-log-reg-failure
interesting:reverse-resume-order
interesting:new_bscan_approach
interesting:bscan_tunnel
interesting:log_output
interesting:haltreq
interesting:deinit
interesting:eclipse_memory_read
interesting:old_fixes_and_eclipse_memory_read
interesting:mpsse_flush
interesting:sba_tests
interesting:riscv-compliance
interesting:wip
interesting:riscv-compliance-dev
interesting:compliance_dev
interesting:fence_i_fix_for_release
interesting:rbb_cleanup
interesting:dmi_read
interesting:add_macos_build
interesting:fix_macbuild
interesting:update_defines
interesting:macbuild
interesting:winbuild
interesting:eclipse_multicore_fix
interesting:FE_402_fix
interesting:gdb_next_port
interesting:print_port
interesting:build32
interesting:travis-nop
interesting:old_triggers
interesting:master
interesting:autoconf
interesting:gitignore-build
interesting:multicore
interesting:release
interesting:race
interesting:nohartstatus
interesting:newprogram
interesting:__archive__
interesting:latest
interesting:openocd64-ad4c3e1
interesting:openocd64-8b80fe1
interesting:openocd64-41b9c69e92d9660cb2eff508f3bc8218a3b3e461
interesting:openocd64-d486b21
interesting:v2018.12.0
interesting:v20181030
interesting:v20180928
interesting:v20180629
interesting:v20171231
interesting:v20170818
interesting:v20170621
interesting:v20170612
interesting:v20170608

2 Commits
riscv ... halt_exami

Author SHA1 Message Date
Tim Newsome a74e59f0fc
Improve user messages. 
Co-authored-by: Jan Matyas <50193733+JanMatCodasip@users.noreply.github.com>
Signed-off-by: Tim Newsome <tim@sifive.com>
 2022-10-05 10:32:47 -07:00
Tim Newsome d4c92a5ac7 target: Try to examine unexamined target in halt() 
Some targets fail to examine during `init`, e.g. for timing reasons. The
right solution is a better config script, but that ends up being
complicated to figure out. This is a bit of a hack, but hopefully
silently fixes the problem so users won't have to deal with it at all.

Change-Id: Ib04d0680eb4136f06c383caa6775dd2581a08ce0
Signed-off-by: Tim Newsome <tim@sifive.com>
 2022-10-04 13:36:18 -07:00
1 changed files with 8 additions and 2 deletions
Show Stats Expand all files Collapse all files

10
src/target/target.c
View File

@ -589,8 +589,14 @@ int target_halt(struct target *target)
int retval;
/* We can't poll until after examine */
if (!target_was_examined(target)) {
LOG_ERROR("Target not examined yet");
return ERROR_FAIL;
/* Try to examine the target right now, in case the target we're
* talking to didn't examine correctly during `init`. */
LOG_TARGET_INFO(target, "Trying to examine unexamined target before halt attempt.");
target_examine();
if (!target_was_examined(target)) {
LOG_TARGET_ERROR(target, "Re-examination before halt failed. Target not examined yet.");
return ERROR_FAIL;
}
}
retval = target->type->halt(target);