interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Compare commits

merge into: interesting:riscv
Branches Tags
interesting:riscv
interesting:examine_unavailable_harts_rebase
interesting:examine_unavailable_harts_squash
interesting:examine_unavailable_harts
interesting:examine_unavailable_harts_backup
interesting:reset_test
interesting:us_xds110
interesting:hypervisor_translate
interesting:dsp5680_build
interesting:examine_command
interesting:halt_examine
interesting:gd32vf103
interesting:set_group
interesting:macro
interesting:s2_increment
interesting:jlink
interesting:buf_sget
interesting:static
interesting:global
interesting:dmstatus_version
interesting:manual_hwbp
interesting:regcache
interesting:vector2
interesting:busy
interesting:mem64
interesting:bscan_optimization
interesting:debug-log-reg-failure
interesting:reverse-resume-order
interesting:new_bscan_approach
interesting:bscan_tunnel
interesting:log_output
interesting:haltreq
interesting:deinit
interesting:eclipse_memory_read
interesting:old_fixes_and_eclipse_memory_read
interesting:mpsse_flush
interesting:sba_tests
interesting:riscv-compliance
interesting:wip
interesting:riscv-compliance-dev
interesting:compliance_dev
interesting:fence_i_fix_for_release
interesting:rbb_cleanup
interesting:dmi_read
interesting:add_macos_build
interesting:fix_macbuild
interesting:update_defines
interesting:macbuild
interesting:winbuild
interesting:eclipse_multicore_fix
interesting:FE_402_fix
interesting:gdb_next_port
interesting:print_port
interesting:build32
interesting:travis-nop
interesting:old_triggers
interesting:master
interesting:autoconf
interesting:gitignore-build
interesting:multicore
interesting:release
interesting:race
interesting:nohartstatus
interesting:newprogram
interesting:__archive__
interesting:latest
interesting:openocd64-ad4c3e1
interesting:openocd64-8b80fe1
interesting:openocd64-41b9c69e92d9660cb2eff508f3bc8218a3b3e461
interesting:openocd64-d486b21
interesting:v2018.12.0
interesting:v20181030
interesting:v20180928
interesting:v20180629
interesting:v20171231
interesting:v20170818
interesting:v20170621
interesting:v20170612
interesting:v20170608
...
pull from: interesting:dmi_read
Branches Tags
interesting:riscv
interesting:examine_unavailable_harts_rebase
interesting:examine_unavailable_harts_squash
interesting:examine_unavailable_harts
interesting:examine_unavailable_harts_backup
interesting:reset_test
interesting:us_xds110
interesting:hypervisor_translate
interesting:dsp5680_build
interesting:examine_command
interesting:halt_examine
interesting:gd32vf103
interesting:set_group
interesting:macro
interesting:s2_increment
interesting:jlink
interesting:buf_sget
interesting:static
interesting:global
interesting:dmstatus_version
interesting:manual_hwbp
interesting:regcache
interesting:vector2
interesting:busy
interesting:mem64
interesting:bscan_optimization
interesting:debug-log-reg-failure
interesting:reverse-resume-order
interesting:new_bscan_approach
interesting:bscan_tunnel
interesting:log_output
interesting:haltreq
interesting:deinit
interesting:eclipse_memory_read
interesting:old_fixes_and_eclipse_memory_read
interesting:mpsse_flush
interesting:sba_tests
interesting:riscv-compliance
interesting:wip
interesting:riscv-compliance-dev
interesting:compliance_dev
interesting:fence_i_fix_for_release
interesting:rbb_cleanup
interesting:dmi_read
interesting:add_macos_build
interesting:fix_macbuild
interesting:update_defines
interesting:macbuild
interesting:winbuild
interesting:eclipse_multicore_fix
interesting:FE_402_fix
interesting:gdb_next_port
interesting:print_port
interesting:build32
interesting:travis-nop
interesting:old_triggers
interesting:master
interesting:autoconf
interesting:gitignore-build
interesting:multicore
interesting:release
interesting:race
interesting:nohartstatus
interesting:newprogram
interesting:__archive__
interesting:latest
interesting:openocd64-ad4c3e1
interesting:openocd64-8b80fe1
interesting:openocd64-41b9c69e92d9660cb2eff508f3bc8218a3b3e461
interesting:openocd64-d486b21
interesting:v2018.12.0
interesting:v20181030
interesting:v20180928
interesting:v20180629
interesting:v20171231
interesting:v20170818
interesting:v20170621
interesting:v20170612
interesting:v20170608

5 Commits
riscv ... dmi_read

Author SHA1 Message Date
Tim Newsome f401f2304f Deal with busy status on dbus_read() request. 
Change-Id: I3699bde01887dfba37d7f420737988248c7fca5b
 2018-01-04 12:53:09 -08:00
Tim Newsome 2ffa3f3382 Comment busy behavior. 
Change-Id: I95e4a70eea636a41f0206b738b1b991d4a3e9249
 2018-01-03 12:34:52 -08:00
Tim Newsome 89481491a7 Properly fix dbus_read() 
Read once, and then get the value that was read in a nop scan.
If it didn't work, increase the time and try again.

Change-Id: Ic0aaa44f5a858526c4b65d546ab2e7267fd17ef5
 2018-01-02 14:32:18 -08:00
Megan Wachs bf22cae558
Update riscv-011.c 
Update comment and remove redundant check
 2018-01-02 12:02:02 -08:00
Tim Newsome e36a16701d In dmi_read(), ignore stale data. 
Fixes Issue #39. Reduces performance about 1%.

Change-Id: I3bfc71cb8e632ecce35c6adeb744177300d54b98
 2017-12-28 15:59:55 -08:00
1 changed files with 19 additions and 7 deletions
Show Stats Expand all files Collapse all files

26
src/target/riscv/riscv-011.c
View File

@ -455,16 +455,28 @@ static uint64_t dbus_read(struct target *target, uint16_t address)
dbus_status_t status; dbus_status_t status;
uint16_t address_in; uint16_t address_in;
unsigned i = 0; /* Assume dbus is idle and there aren't any busy/error states pending.
do { * If there happens to be a busy state pending, we will clear it after we
status = dbus_scan(target, &address_in, &value, DBUS_OP_READ, address, 0); * discover it as part of the NOP scan. */
for (unsigned i = 0; i < 256; i++) {
status = dbus_scan(target, NULL, NULL, DBUS_OP_READ, address, 0);
if (status == DBUS_STATUS_BUSY) {
increase_dbus_busy_delay(target);
continue;
}
status = dbus_scan(target, &address_in, &value, DBUS_OP_NOP, address, 0);
if (status == DBUS_STATUS_BUSY) if (status == DBUS_STATUS_BUSY)
increase_dbus_busy_delay(target); increase_dbus_busy_delay(target);
} while (((status == DBUS_STATUS_BUSY) || (address_in != address)) && else if (address_in != address)
i++ < 256); LOG_ERROR("Tried to read from 0x%x, but actually read from 0x%x",
address, address_in);
else
break;
}
if (status != DBUS_STATUS_SUCCESS) if (status != DBUS_STATUS_SUCCESS)
LOG_ERROR("failed read from 0x%x; value=0x%" PRIx64 ", status=%d\n", address, value, status); LOG_ERROR("failed read from 0x%x; value=0x%" PRIx64 ", status=%d",
address, value, status);
return value; return value;
} }
@ -479,7 +491,7 @@ static void dbus_write(struct target *target, uint16_t address, uint64_t value)
increase_dbus_busy_delay(target); increase_dbus_busy_delay(target);
} }
if (status != DBUS_STATUS_SUCCESS) if (status != DBUS_STATUS_SUCCESS)
LOG_ERROR("failed to write 0x%" PRIx64 " to 0x%x; status=%d\n", value, address, status); LOG_ERROR("failed to write 0x%" PRIx64 " to 0x%x; status=%d", value, address, status);
} }
/*** scans "class" ***/ /*** scans "class" ***/