interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

jtag: rewrite command 'jtag arp_init' as COMMAND_HANDLER 

While there add the mandatory 'usage' field.

Change-Id: I3491ed79d11c5a3e81cc9afd2423da14b8df72ff
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7495
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2022-12-19 18:18:48 +01:00
parent 2774125257
commit ff0fdcf614
1 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/jtag/tcl.c
View File

@ -664,22 +664,12 @@ static void jtag_tap_handle_event(struct jtag_tap *tap, enum jtag_event e)
} }
} }
static int jim_jtag_arp_init(Jim_Interp *interp, int argc, Jim_Obj *const *argv) COMMAND_HANDLER(handle_jtag_arp_init)
{ {
struct jim_getopt_info goi; if (CMD_ARGC != 0)
jim_getopt_setup(&goi, interp, argc-1, argv + 1); return ERROR_COMMAND_SYNTAX_ERROR;
if (goi.argc != 0) {
Jim_WrongNumArgs(goi.interp, 1, goi.argv-1, "(no params)"); return jtag_init_inner(CMD_CTX);
return JIM_ERR;
}
struct command_context *context = current_command_context(interp);
int e = jtag_init_inner(context);
if (e != ERROR_OK) {
Jim_Obj *obj = Jim_NewIntObj(goi.interp, e);
Jim_SetResultFormatted(goi.interp, "error: %#s", obj);
return JIM_ERR;
}
return JIM_OK;
} }
static int jim_jtag_arp_init_reset(Jim_Interp *interp, int argc, Jim_Obj *const *argv) static int jim_jtag_arp_init_reset(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
@ -843,10 +833,11 @@ static const struct command_registration jtag_subcommand_handlers[] = {
{ {
.name = "arp_init", .name = "arp_init",
.mode = COMMAND_ANY, .mode = COMMAND_ANY,
.jim_handler = jim_jtag_arp_init, .handler = handle_jtag_arp_init,
.help = "Validates JTAG scan chain against the list of " .help = "Validates JTAG scan chain against the list of "
"declared TAPs using just the four standard JTAG " "declared TAPs using just the four standard JTAG "
"signals.", "signals.",
.usage = "",
}, },
{ {
.name = "arp_init-reset", .name = "arp_init-reset",