From faf7202f8ee65f21a96ea1ebf33f7157c97065f0 Mon Sep 17 00:00:00 2001 From: Antonio Borneo Date: Mon, 1 May 2023 00:55:15 +0200 Subject: [PATCH] nand: declare exported function in core.h Don't use 'extern' in a C file, but declare the exported function in a H file. This helps validating the function prototype across declaration and use. Detected through 'sparse' tool. Change-Id: I2c22b084fb513f4b3b1b1db96dfbc8fa4bfe7238 Signed-off-by: Antonio Borneo Reviewed-on: https://review.openocd.org/c/openocd/+/7666 Tested-by: jenkins --- src/flash/nand/core.h | 2 ++ src/flash/nand/lpc32xx.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/flash/nand/core.h b/src/flash/nand/core.h index 19c53d1da..8f54493af 100644 --- a/src/flash/nand/core.h +++ b/src/flash/nand/core.h @@ -202,6 +202,8 @@ int nand_calculate_ecc(struct nand_device *nand, const uint8_t *dat, uint8_t *ecc_code); int nand_calculate_ecc_kw(struct nand_device *nand, const uint8_t *dat, uint8_t *ecc_code); +int nand_correct_data(struct nand_device *nand, u_char *dat, + u_char *read_ecc, u_char *calc_ecc); int nand_register_commands(struct command_context *cmd_ctx); diff --git a/src/flash/nand/lpc32xx.c b/src/flash/nand/lpc32xx.c index f8b59b357..1fdae9fe5 100644 --- a/src/flash/nand/lpc32xx.c +++ b/src/flash/nand/lpc32xx.c @@ -24,8 +24,6 @@ static int lpc32xx_reset(struct nand_device *nand); static int lpc32xx_controller_ready(struct nand_device *nand, int timeout); static int lpc32xx_tc_ready(struct nand_device *nand, int timeout); -extern int nand_correct_data(struct nand_device *nand, u_char *dat, - u_char *read_ecc, u_char *calc_ecc); /* These are offset with the working area in IRAM when using DMA to * read/write data to the SLC controller.