interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

target: arm_dap: rewrite command 'dap names' as COMMAND_HANDLER 

While there, format in a human readable way the output list by
using one line per dap name.

Change-Id: I24a47350105b90db15808c61790f05d807120739
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7498
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2022-12-19 18:35:23 +01:00
parent fbb7a50cbd
commit f76e67a440
1 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/target/arm_dap.c
View File

@ -421,20 +421,16 @@ static int jim_dap_create(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
return dap_create(&goi); return dap_create(&goi);
} }
static int jim_dap_names(Jim_Interp *interp, int argc, Jim_Obj *const *argv) COMMAND_HANDLER(handle_dap_names)
{ {
struct arm_dap_object *obj; if (CMD_ARGC != 0)
return ERROR_COMMAND_SYNTAX_ERROR;
if (argc != 1) { struct arm_dap_object *obj;
Jim_WrongNumArgs(interp, 1, argv, "Too many parameters"); list_for_each_entry(obj, &all_dap, lh)
return JIM_ERR; command_print(CMD, "%s", obj->name);
}
Jim_SetResult(interp, Jim_NewListObj(interp, NULL, 0)); return ERROR_OK;
list_for_each_entry(obj, &all_dap, lh) {
Jim_ListAppendElement(interp, Jim_GetResult(interp),
Jim_NewStringObj(interp, obj->name, -1));
}
return JIM_OK;
} }
COMMAND_HANDLER(handle_dap_init) COMMAND_HANDLER(handle_dap_init)
@ -500,7 +496,7 @@ static const struct command_registration dap_subcommand_handlers[] = {
{ {
.name = "names", .name = "names",
.mode = COMMAND_ANY, .mode = COMMAND_ANY,
.jim_handler = jim_dap_names, .handler = handle_dap_names,
.usage = "", .usage = "",
.help = "Lists all registered DAP instances by name", .help = "Lists all registered DAP instances by name",
}, },