interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

TARGET: review handle_load_image_command() 

Collect variable definitions.
Report syntax error to command dispatcher.
Propagate error when unable to open file.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
This commit is contained in:
Antonio Borneo 2010-10-12 16:47:24 +08:00 committed by Øyvind Harboe
parent 2ee47b22c6
commit ed44447e3d
1 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/target/target.c
View File

@ -2596,33 +2596,25 @@ COMMAND_HANDLER(handle_load_image_command)
COMMAND_HANDLER(handle_dump_image_command) COMMAND_HANDLER(handle_dump_image_command)
{ {
struct fileio fileio; struct fileio fileio;
uint8_t buffer[560]; uint8_t buffer[560];
int retvaltemp; int retval, retvaltemp;
uint32_t address, size;
struct duration bench;
struct target *target = get_current_target(CMD_CTX); struct target *target = get_current_target(CMD_CTX);
if (CMD_ARGC != 3) if (CMD_ARGC != 3)
{ return ERROR_COMMAND_SYNTAX_ERROR;
command_print(CMD_CTX, "usage: dump_image <filename> <address> <size>");
return ERROR_OK;
}
uint32_t address;
COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], address); COMMAND_PARSE_NUMBER(u32, CMD_ARGV[1], address);
uint32_t size;
COMMAND_PARSE_NUMBER(u32, CMD_ARGV[2], size); COMMAND_PARSE_NUMBER(u32, CMD_ARGV[2], size);
if (fileio_open(&fileio, CMD_ARGV[0], FILEIO_WRITE, FILEIO_BINARY) != ERROR_OK) retval = fileio_open(&fileio, CMD_ARGV[0], FILEIO_WRITE, FILEIO_BINARY);
{ if (retval != ERROR_OK)
return ERROR_OK; return retval;
}
struct duration bench;
duration_start(&bench); duration_start(&bench);
int retval = ERROR_OK; retval = ERROR_OK;
while (size > 0) while (size > 0)
{ {
size_t size_written; size_t size_written;