interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

target: change prototype of handle_md_output() 

To prepare for handling TCL return values consistently, all calls
to command_print/command_print_sameline should be ready to switch
to CMD as first parameter.

Change prototype of handle_md_output() to pass CMD instead of
CMD_CTX.

This change was part of http://openocd.zylin.com/1815 from Paul
Fertser and has been extracted and rebased to simplify the review.

Change-Id: I2150201fad3fd3bc0be89249dcbd314b38a6f860
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/5074
Tested-by: jenkins
This commit is contained in:
Paul Fertser 2019-04-01 05:14:26 +02:00 committed by Tomas Vanek
parent d50e92e7f7
commit eaa70635dc
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/target/target.c
View File

@ -3125,7 +3125,7 @@ COMMAND_HANDLER(handle_step_command)
return target->type->step(target, current_pc, addr, 1); return target->type->step(target, current_pc, addr, 1);
} }
static void handle_md_output(struct command_context *cmd_ctx, static void handle_md_output(struct command_invocation *cmd,
struct target *target, target_addr_t address, unsigned size, struct target *target, target_addr_t address, unsigned size,
unsigned count, const uint8_t *buffer) unsigned count, const uint8_t *buffer)
{ {
@ -3183,7 +3183,7 @@ static void handle_md_output(struct command_context *cmd_ctx,
value_fmt, value); value_fmt, value);
if ((i % line_modulo == line_modulo - 1) || (i == count - 1)) { if ((i % line_modulo == line_modulo - 1) || (i == count - 1)) {
command_print(cmd_ctx, "%s", output); command_print(cmd->ctx, "%s", output);
output_len = 0; output_len = 0;
} }
} }
@ -3240,7 +3240,7 @@ COMMAND_HANDLER(handle_md_command)
struct target *target = get_current_target(CMD_CTX); struct target *target = get_current_target(CMD_CTX);
int retval = fn(target, address, size, count, buffer); int retval = fn(target, address, size, count, buffer);
if (ERROR_OK == retval) if (ERROR_OK == retval)
handle_md_output(CMD_CTX, target, address, size, count, buffer); handle_md_output(CMD, target, address, size, count, buffer);
free(buffer); free(buffer);