interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cortex-A8: parts of examine() run just once 

The examine() method has some conceptual breakage.  Cope
with it by manually splitting out the run-once parts from
the after-each-reset parts ... this gets rid of memory
leaks and speeds up resets after the first one.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
This commit is contained in:
David Brownell 2009-11-19 10:47:31 -08:00
parent c049033fde
commit e3ed06579b
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/target/cortex_a8.c
View File

@ -1362,7 +1362,7 @@ static int cortex_a8_handle_target_request(void *priv)
* Cortex-A8 target information and configuration * Cortex-A8 target information and configuration
*/ */
static int cortex_a8_examine(struct target *target) static int cortex_a8_examine_first(struct target *target)
{ {
struct cortex_a8_common *cortex_a8 = target_to_cortex_a8(target); struct cortex_a8_common *cortex_a8 = target_to_cortex_a8(target);
struct armv7a_common *armv7a = &cortex_a8->armv7a_common; struct armv7a_common *armv7a = &cortex_a8->armv7a_common;
@ -1447,10 +1447,21 @@ static int cortex_a8_examine(struct target *target)
LOG_DEBUG("Configured %i hw breakpoint pairs and %i hw watchpoint pairs", LOG_DEBUG("Configured %i hw breakpoint pairs and %i hw watchpoint pairs",
cortex_a8->brp_num , cortex_a8->wrp_num); cortex_a8->brp_num , cortex_a8->wrp_num);
/* Configure core debug access */
cortex_a8_init_debug_access(target);
target_set_examined(target); target_set_examined(target);
return ERROR_OK;
}
static int cortex_a8_examine(struct target *target)
{
int retval = ERROR_OK;
/* don't re-probe hardware after each reset */
if (!target_was_examined(target))
retval = cortex_a8_examine_first(target);
/* Configure core debug access */
if (retval == ERROR_OK)
retval = cortex_a8_init_debug_access(target);
return retval; return retval;
} }