interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

jtag: do not use jtag_get_error() 

normal code should not call jtag_get_error(), but rather check
the return code from jtag_execute_queue().

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This commit is contained in:
Øyvind Harboe 2010-06-21 13:25:06 +02:00
parent 7013b960fe
commit dcba070958
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/target/adi_v5_jtag.c
View File

@ -120,7 +120,7 @@ int adi_jtag_dp_scan(struct adiv5_dap *dap,
jtag_add_runtest(dap->memaccess_tck, jtag_add_runtest(dap->memaccess_tck,
TAP_IDLE); TAP_IDLE);
return jtag_get_error(); return ERROR_OK;
} }
/** /**
@ -343,14 +343,11 @@ static int jtag_idcode_q_read(struct adiv5_dap *dap,
fields[0].in_value = (void *) data; fields[0].in_value = (void *) data;
jtag_add_dr_scan(jtag_info->tap, 1, fields, TAP_IDLE); jtag_add_dr_scan(jtag_info->tap, 1, fields, TAP_IDLE);
retval = jtag_get_error();
if (retval != ERROR_OK)
return retval;
jtag_add_callback(arm_le_to_h_u32, jtag_add_callback(arm_le_to_h_u32,
(jtag_callback_data_t) data); (jtag_callback_data_t) data);
return retval; return ERROR_OK;
} }
static int jtag_dp_q_read(struct adiv5_dap *dap, unsigned reg, static int jtag_dp_q_read(struct adiv5_dap *dap, unsigned reg,

2
src/xsvf/xsvf.c
View File

@ -331,7 +331,7 @@ COMMAND_HANDLER(handle_xsvf_command)
else else
jtag_add_pathmove(pathlen, path); jtag_add_pathmove(pathlen, path);
result = jtag_get_error(); result = jtag_execute_queue();
if (result != ERROR_OK) { if (result != ERROR_OK) {
LOG_ERROR("XSVF: pathmove error %d", LOG_ERROR("XSVF: pathmove error %d",
result); result);