From dca76cd5dad974996e7231ba0ede544c626ba43d Mon Sep 17 00:00:00 2001 From: Paul Fertser Date: Tue, 26 Nov 2024 22:55:55 +0200 Subject: [PATCH] rtos: mqx: replace malloc+strcpy with strdup Using strcpy is potentially dangerous so just use a safer and easier way to do the same. Signed-off-by: Paul Fertser Change-Id: Id85f3b7f8af1eaf14c9951ae710546d2437c70b5 Reviewed-on: https://review.openocd.org/c/openocd/+/8597 Reviewed-by: Antonio Borneo Tested-by: jenkins --- src/rtos/mqx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/rtos/mqx.c b/src/rtos/mqx.c index b4a182135..90154db3f 100644 --- a/src/rtos/mqx.c +++ b/src/rtos/mqx.c @@ -380,10 +380,9 @@ static int mqx_update_threads( rtos->thread_details[i].threadid = task_id; rtos->thread_details[i].exists = true; /* set thread name */ - rtos->thread_details[i].thread_name_str = malloc(strlen((void *)task_name) + 1); + rtos->thread_details[i].thread_name_str = strdup((char *)task_name); if (!rtos->thread_details[i].thread_name_str) return ERROR_FAIL; - strcpy(rtos->thread_details[i].thread_name_str, (void *)task_name); /* set thread extra info * - task state * - task address