interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

target: rewrite command 'target types' as COMMAND_HANDLER 

Print one entry per line.
While there add the mandatory 'usage' field.

Change-Id: I135556e12154e33fdbd0f71d89f6fe37c69813b7
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7509
Tested-by: jenkins
This commit is contained in:
Antonio Borneo 2022-12-19 23:54:10 +01:00
parent 26f457896c
commit d9d698103e
1 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/target/target.c
View File

@ -6377,18 +6377,15 @@ COMMAND_HANDLER(handle_target_current)
return ERROR_OK; return ERROR_OK;
} }
static int jim_target_types(Jim_Interp *interp, int argc, Jim_Obj *const *argv) COMMAND_HANDLER(handle_target_types)
{ {
if (argc != 1) { if (CMD_ARGC != 0)
Jim_WrongNumArgs(interp, 1, argv, "Too many parameters"); return ERROR_COMMAND_SYNTAX_ERROR;
return JIM_ERR;
} for (unsigned int x = 0; target_types[x]; x++)
Jim_SetResult(interp, Jim_NewListObj(interp, NULL, 0)); command_print(CMD, "%s", target_types[x]->name);
for (unsigned x = 0; target_types[x]; x++) {
Jim_ListAppendElement(interp, Jim_GetResult(interp), return ERROR_OK;
Jim_NewStringObj(interp, target_types[x]->name, -1));
}
return JIM_OK;
} }
static int jim_target_names(Jim_Interp *interp, int argc, Jim_Obj *const *argv) static int jim_target_names(Jim_Interp *interp, int argc, Jim_Obj *const *argv)
@ -6526,9 +6523,10 @@ static const struct command_registration target_subcommand_handlers[] = {
{ {
.name = "types", .name = "types",
.mode = COMMAND_ANY, .mode = COMMAND_ANY,
.jim_handler = jim_target_types, .handler = handle_target_types,
.help = "Returns the available target types as " .help = "Returns the available target types as "
"a list of strings", "a list of strings",
.usage = "",
}, },
{ {
.name = "names", .name = "names",