interesting
/
riscv-openocd
mirror of https://github.com/riscv/riscv-openocd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

jtag/tcl: Remove no-op free 

And use calloc instead of malloc+memset.

Change-Id: Icc1ed6e34904972bb5d3728307dcae5c55b32fc3
Signed-off-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>
Reviewed-on: http://openocd.zylin.com/1666
Tested-by: jenkins
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
This commit is contained in:
Andreas Fritiofson 2013-09-28 16:29:50 +02:00 committed by Spencer Oliver
parent 2a0ed1ee7f
commit d96010ae71
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/jtag/tcl.c
View File

@ -1120,17 +1120,12 @@ COMMAND_HANDLER(handle_irscan_command)
return ERROR_COMMAND_SYNTAX_ERROR; return ERROR_COMMAND_SYNTAX_ERROR;
} }
size_t fields_len = sizeof(struct scan_field) * num_fields; fields = calloc(num_fields, sizeof(*fields));
fields = malloc(fields_len);
memset(fields, 0, fields_len);
int retval; int retval;
for (i = 0; i < num_fields; i++) { for (i = 0; i < num_fields; i++) {
tap = jtag_tap_by_string(CMD_ARGV[i*2]); tap = jtag_tap_by_string(CMD_ARGV[i*2]);
if (tap == NULL) { if (tap == NULL) {
int j;
for (j = 0; j < i; j++)
free((void *)fields[j].out_value);
free(fields); free(fields);
command_print(CMD_CTX, "Tap: %s unknown", CMD_ARGV[i*2]); command_print(CMD_CTX, "Tap: %s unknown", CMD_ARGV[i*2]);