From d59bf1d96ac97aa4238e3d7734fb927c15bcaaef Mon Sep 17 00:00:00 2001 From: Erhan Kurubas Date: Mon, 9 May 2022 23:01:35 +0200 Subject: [PATCH] flash: fix clang static analyzer build errors Fixes "variable set but not used" errors. Tested with Homebrew clang version 13.0.1 Signed-off-by: Erhan Kurubas Change-Id: Ia90baf5b4857db2b5569ebe6adbbb832de772aad Reviewed-on: https://review.openocd.org/c/openocd/+/6971 Tested-by: jenkins Reviewed-by: Antonio Borneo --- src/flash/nand/davinci.c | 2 -- src/flash/nor/dsp5680xx_flash.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/src/flash/nand/davinci.c b/src/flash/nand/davinci.c index 84f8e3480..1aa7ffc05 100644 --- a/src/flash/nand/davinci.c +++ b/src/flash/nand/davinci.c @@ -605,8 +605,6 @@ static int davinci_write_page_ecc4infix(struct nand_device *nand, uint32_t page, /* write this "out-of-band" data -- infix */ davinci_write_block_data(nand, oob, 16); oob += 16; - oob_size -= 16; - } while (data_size); /* the last data and OOB writes included the spare area */ diff --git a/src/flash/nor/dsp5680xx_flash.c b/src/flash/nor/dsp5680xx_flash.c index 5e8eec30f..858b66981 100644 --- a/src/flash/nor/dsp5680xx_flash.c +++ b/src/flash/nor/dsp5680xx_flash.c @@ -45,14 +45,11 @@ static int dsp5680xx_build_sector_list(struct flash_bank *bank) { - uint32_t offset = HFM_FLASH_BASE_ADDR; - bank->sectors = malloc(sizeof(struct flash_sector) * bank->num_sectors); for (unsigned int i = 0; i < bank->num_sectors; ++i) { bank->sectors[i].offset = i * HFM_SECTOR_SIZE; bank->sectors[i].size = HFM_SECTOR_SIZE; - offset += bank->sectors[i].size; bank->sectors[i].is_erased = -1; bank->sectors[i].is_protected = -1; }