interesting
/
riscv-openocd
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

gdb server: Add back support to disable the gdb server via the gdb_port config 

As per the documentation, used "disabled" as the value to disable, as this
is the same value to disable the telnet and tcl server.

Change-Id: Idc4a8580098ec1107dcc6e1f59e817ecdebc38ac
Signed-off-by: Sandeep Mistry <s.mistry@arduino.cc>
Reviewed-on: http://openocd.zylin.com/3175
Tested-by: jenkins
Reviewed-by: Cristian Maglie
Reviewed-by: Spencer Oliver <spen@spen-soft.co.uk>
This commit is contained in:
Sandeep Mistry 2015-12-23 12:10:32 -05:00 committed by Andreas Fritiofson
parent f109a93075
commit ca6ccad439
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/openocd.texi
View File

@ -2109,7 +2109,7 @@ communicate via pipes(stdin/out or named pipes). The name
the normal use cases. the normal use cases.
No arguments reports GDB port. "pipe" means listen to stdin No arguments reports GDB port. "pipe" means listen to stdin
output to stdout, an integer is base port number, "disable" output to stdout, an integer is base port number, "disabled"
disables the gdb server. disables the gdb server.
When using "pipe", also use log_output to redirect the log When using "pipe", also use log_output to redirect the log

7
src/server/gdb_server.c
View File

@ -2921,6 +2921,11 @@ static int gdb_target_start(struct target *target, const char *port)
static int gdb_target_add_one(struct target *target) static int gdb_target_add_one(struct target *target)
{ {
if (strcmp(gdb_port, "disabled") == 0) {
LOG_INFO("gdb port disabled");
return ERROR_OK;
}
/* one gdb instance per smp list */ /* one gdb instance per smp list */
if ((target->smp) && (target->gdb_service)) if ((target->smp) && (target->gdb_service))
return ERROR_OK; return ERROR_OK;
@ -3114,7 +3119,7 @@ static const struct command_registration gdb_command_handlers[] = {
"server listens for the next port number after the " "server listens for the next port number after the "
"base port number specified. " "base port number specified. "
"No arguments reports GDB port. \"pipe\" means listen to stdin " "No arguments reports GDB port. \"pipe\" means listen to stdin "
"output to stdout, an integer is base port number, \"disable\" disables " "output to stdout, an integer is base port number, \"disabled\" disables "
"port. Any other string is are interpreted as named pipe to listen to. " "port. Any other string is are interpreted as named pipe to listen to. "
"Output pipe is the same name as input pipe, but with 'o' appended.", "Output pipe is the same name as input pipe, but with 'o' appended.",
.usage = "[port_num]", .usage = "[port_num]",